|Re: [cross-project-issues-dev] ACTION REQUIRED from RAP / REDDEER / WEBTOOLS - respin of Eclipse Platform RC2a and the status on removing slf4j 2.0.0 alpha|
The simrel aggregator is reenabled (thanks Fred!), let's test the snapshot there to give maximum confidence that what we have works.BTW to other projects not involved in this respin activity, please continue to hold off changing simrel until after the release.Thanks,JonahOn Thu., Jun. 10, 2021, 15:15 Jonah Graham, <jonah@xxxxxxxxxxxxxxxx> wrote:Hi Nitin,You can/should revert the change at the same time you provide a WTP build with Jetty 10.0.5 (snapshot or not).I can run the test locally, or we can all contribute our snapshot version to simrel and test there.@Frederic Gurr has disabled the build, until it is reenabled we'll have to test locally and I am happy to do that.Thanks,JonahOn Thu., Jun. 10, 2021, 14:56 Nitin Dahyabhai, <thatnitind@xxxxxxxxx> wrote:I'm doing a build against the 10.0.5 snapshot. The corresponding WTP jetty site has been updated to not have the SLF4J API bundle in it. Yesterday we added the 10.0.4 site to the webtools.aggrcon to provide the slf4j 2.0.0 alpha1 and unblock others; should I remove that from the aggrcon file now so that we're not contributing that and 10.0.4 any more, or wait to do it until after your test, Jonah?On Thu, Jun 10, 2021 at 1:52 PM Markus Knauer <mknauer@xxxxxxxxxxxxxxxxx> wrote:We (RAP) are consuming the Jetty bundles from WTP (https://download.eclipse.org/webtools/jetty/...), and of course, other bundles from Platform.Therefore I'd like to wait until we can get the updated bundles from there. If the update appears in the next hours, I can trigger new RAP builds.ThanksMarkusOn Thu, 10 Jun 2021 at 18:49, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:Hi folks,Sravan has provided me with a link to what should represent Platform's contribution based on the jetty snapshot.I don't think we need to wait for a respin of the snapshot for the source bundle issue that Sravan identified.If other projects (RAP / Webtools/ Reddeer) can do the same, or provide me with build instructions I can smoke test the integration of everything in SimRel/EPP and make sure it all looks good and try to report back to Jetty so they can make their release.ThanksJonahOn Thu, 10 Jun 2021 at 12:26, Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx> wrote:
Triggered a platform build with latest 10.0.5-SNAPSHOT. But there is issue in the source bundles as they contain temporary files https://github.com/eclipse/jetty.project/issues/6354#issuecomment-858764165
The snapshot is ready https://github.com/eclipse/jetty.project/issues/6354#issuecomment-858733158
On Thu., Jun. 10, 2021, 10:23 Jonah Graham, <jonah@xxxxxxxxxxxxxxxx> wrote:
We are making very good progress on resolving this issue, in no part thanks to everyone that has been super responsive in updating their bits.
I checked all the EPP packages and (as expected) only JEE has slf4j.api_2.0.0.alpha1.jar. All the packages (also as expected) have org.slf4j.api_1.7.30.v20200204-2150.jar (including JEE).
The Jetty project is just about to push out a snapshot (https://github.com/eclipse/jetty.project/issues/6390) of 10.0.5 that fully resolves the slf4j 2.0.0 alpha1 dependency so that the SimRel and JEE package won't have alpha1 jar anymore.
To reduce the change of a turnaround time again we can collectively test that the 10.0.5 snapshot resolves all the issues. Note that this a further 10.0.5 snapshot than we had yesterday.
RIght now, I don't know how to do this test without a full respin of everything (platform , redeer(?) , webtools, rap).
Any suggestions are very welcome.
On Wed, 9 Jun 2021 at 16:56, Ondrej Dockal <odockal@xxxxxxxxxx> wrote:
Jonah, thanks for taking care of this. If we will revert it after RedDeer is pushed, I think it is safe to give it a try. Also, If Jetty should be built somewhere with a fix it might provide a space for updating all deps in all project, though, in quite late time.
On Wed, Jun 9, 2021 at 10:45 PM Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/181738 decouples the reddeer contribution from webtools which means if you think it is ok you can merge that so reddeer can be merged.
On Wed, 9 Jun 2021 at 16:25, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
AFAICT the problem is that WTP is also pulling in org.slf4j 2.0 from reddeer.
15:53:01 Missing requirement: Jetty :: JNDI Naming 10.0.4 (org.eclipse.jetty.jndi 10.0.4) requires 'java.package; org.slf4j [2.0.0,3.0.0)' but it could not be found
So because you are (correctly) removing slf4j 2.0, it is unintentionally breaking WTP.
Nitin is working on fixing up the WTP contribution. I don't think there is actually anything wrong with reddeer's contribution, we just need a resolution of WTP first.
I will push a patch that verifies the above in a moment.
On Wed, 9 Jun 2021 at 16:15, Ondrej Dockal <odockal@xxxxxxxxxx> wrote:
Unfortunately, I am still not able to pass aggregator validation, this time it is jetty complaining about missing org.slf4j [2.0.0,3.0.0) as can be seen in . I am not really sure about what I can do about it from my side. There is a reopened bugzilla  and PR on jetty project to handle this bundle dep. range for org.slf4j, but who knows when it will be fixed.
I am trying in a meantime to omit any bundles from my plugins in release, not sure if that can help.
On Wed, Jun 9, 2021 at 6:47 PM Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
I think your analysis is correct. RAP tools publishes jetty to its p2 site, but does not include the slf4j so just happened to pick it up from Platform until they removed it, now it picks it up from Reddeer.
Not sure what the issues with removing slf4j 2.0.0 alpha is. Do you mean that RAP references it in too many places? If you mean too many projects, then you might be right, but I hope not. Hopefully with rap, wtp, and reddeer making their update we can get rid of it from the 2021-06 release entirely.
I think the RC2 contribution of WTP only validated because Reddeer is still publishing slf4j 2.0.
On Wed, 9 Jun 2021 at 10:55, Ondrej Dockal <odockal@xxxxxxxxxx> wrote:
Gerrit aggregator validation job  is failing for me due to RAP requiring jetty 10.0.3 and that transitively requires slf4j in 2.0.0 +, I guess I have to wait for you to update jetty deps to make it work, right?
On Wed, Jun 9, 2021 at 4:50 PM Markus Knauer <mknauer@xxxxxxxxxxxxxxxxx> wrote:
Switching to Jetty 10.0.4 seems to be doable for RAP, especially because the Webtools team was so kind to give us access to their p2 repository for building. I will try that now.
slf4j 2.0.0 is a different issue. It was required until today, and is now referenced in too many places. I am not sure if it will be possible to remove it in a quick and safe manner in a last build towards RC2.
On Wed, 9 Jun 2021 at 15:32, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
Eclipse Platform have successfully updated their contribution (Thanks Sravan, Thomas, Jetty team and anyone else who got this done that I don't know about!) to SimRel to their RC2a build and that means that Eclipse Platform now no longer contributes the alpha 2.0.0 version.
However other projects still are contributing the bundle to simrel because they are republishing parts or all of Platform RC2 or earlier or jetty 10 from other sources.
Can both reddeer and rap projects look at their contribution to ensure that they are not contributing slf4j 2.0.0 alpha to the simrel please.
As Platform have updated to Jetty 10.0.4, I also see that rap has Jetty 10.0.3 contributed to simrel and webtools has 10.0.2 contributed to webtools. All three versions are in the simrel output repo!
Back to the top