Re: [cross-project-issues-dev] Gerrit ECA check saying I am not a commit

[Frederic Gurr <frederic.gurr@xxxxxxxxxxxxxxxxxxxxxx>]

Hi Jonah,

This is caused by the fact that SimRel is not a real Eclipse project and
the ECA can't check if you are a committer.
We are working on a solution.

In the meantime, I should be able to merge Gerrit reviews for SimRel.

Regards,

Fred

On 16.12.20 00:22, Jonah Graham wrote:
> Hi Christopher and team,
> 
> It doesn't look like the new ECA check is correct for simrel now. I have
> just had a failed push to simrel saying I am not a committer. Perhaps
> simrel's special case is getting in the way here?
> 
> $ git push origin HEAD:refs/for/master
> Enumerating objects: 5, done.
> Counting objects: 100% (5/5), done.
> Delta compression using up to 8 threads
> Compressing objects: 100% (3/3), done.
> Writing objects: 100% (3/3), 337 bytes | 337.00 KiB/s, done.
> Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
> remote: Resolving deltas: 100% (2/2)
> remote: Processing changes: refs: 1, done    
> remote: commit fd3ef88: ----------
> remote: commit fd3ef88: Reviewing commit: fd3ef88e
> remote: commit fd3ef88: Authored by: Jonah Graham
> <jonah@xxxxxxxxxxxxxxxx <mailto:jonah@xxxxxxxxxxxxxxxx>>
> remote: commit fd3ef88:
> remote: commit fd3ef88: Reviewing commit:
> fd3ef88ee544e8f10000ae798c0e27f44fc5c0cf
> remote: commit fd3ef88: Authored by: Jonah Graham
> <jonah@xxxxxxxxxxxxxxxx <mailto:jonah@xxxxxxxxxxxxxxxx>>
> remote: commit fd3ef88: The author is not a committer on the project.
> remote: commit fd3ef88: The author has a current Eclipse Contributor
> Agreement (ECA) on file.
> remote: commit fd3ef88: The author has not signed-off on the contribution.
> remote: If there are multiple commits, please ensure that each commit is
> signed-off.
> remote: commit fd3ef88:
> remote: commit fd3ef88: Please see http://wiki.eclipse.org/ECA
> To ssh://git.eclipse.org:29418/simrel/org.eclipse.simrel.build
> <http://git.eclipse.org:29418/simrel/org.eclipse.simrel.build>
>  ! [remote rejected]   HEAD -> refs/for/master (commit fd3ef88: The
> contributor must sign-off on the contribution.)
> error: failed to push some refs to
> 'ssh://git.eclipse.org:29418/simrel/org.eclipse.simrel.build
> <http://git.eclipse.org:29418/simrel/org.eclipse.simrel.build>'
> 
> A test for CDT worked fine:
> 
>  $ git push origin HEAD:refs/for/cdt_10_1
> Enumerating objects: 5, done.
> Counting objects: 100% (5/5), done.
> Delta compression using up to 8 threads
> Compressing objects: 100% (3/3), done.
> Writing objects: 100% (3/3), 364 bytes | 364.00 KiB/s, done.
> Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
> remote: Resolving deltas: 100% (2/2)
> remote: Processing changes: refs: 1, new: 1, done    
> remote: commit 0b276a5: ----------
> remote: commit 0b276a5: Reviewing commit: 0b276a5d
> remote: commit 0b276a5: Authored by: Jonah Graham
> <jonah@xxxxxxxxxxxxxxxx <mailto:jonah@xxxxxxxxxxxxxxxx>>
> remote: commit 0b276a5:
> remote: commit 0b276a5: Reviewing commit:
> 0b276a5d705da331f07cb95b4bc5f16b6194d88c
> remote: commit 0b276a5: Authored by: Jonah Graham
> <jonah@xxxxxxxxxxxxxxxx <mailto:jonah@xxxxxxxxxxxxxxxx>>
> remote: commit 0b276a5: The author is a committer on the project.
> remote: commit 0b276a5:
> remote: commit 0b276a5: This commit passes Eclipse validation.
> remote:
> remote: SUCCESS
> remote:
> remote:   https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/173844 Dummy
> commit [NEW]
> remote:
> To ssh://git.eclipse.org:29418/cdt/org.eclipse.cdt.git
> <http://git.eclipse.org:29418/cdt/org.eclipse.cdt.git>
>  * [new reference]         HEAD -> refs/for/cdt_10_1
> 
> 
> Thanks,
> Jonah
> 
> 
> ~~~
> Jonah Graham
> Kichwa Coders
> www.kichwacoders.com <http://www.kichwacoders.com>
> 
> 
> On Mon, 14 Dec 2020 at 13:30, Christopher Guindon
> <chris.guindon@xxxxxxxxxxxxxxxxxxxxxx
> <mailto:chris.guindon@xxxxxxxxxxxxxxxxxxxxxx>> wrote:
> 
>     Hi All,
> 
>     The new Gerrit ECA plugin is now live! 
> 
>     We did a few tests and the system was able to detect that I was a
>     committer on an Eclipse project.
> 
>     Please let us know if you encounter any issues with the Gerrit
>     plugin this week by posting a comment on this bug:
>     https://bugs.eclipse.org/bugs/show_bug.cgi?id=569703 
> 
>     Thank you!
> 
>     On Fri, Dec 11, 2020 at 2:38 PM Christopher Guindon
>     <chris.guindon@xxxxxxxxxxxxxxxxxxxxxx
>     <mailto:chris.guindon@xxxxxxxxxxxxxxxxxxxxxx>> wrote:
> 
>         Good Afternoon All,
> 
>         We did not deploy the plugin this week however, we believe that
>         all the known issues are now fixed.
> 
>         Our next step is to try this again on Monday at 18:00 GMT.  
> 
>         I will post an update to this mailing list once the update is
>         done and ask our projects to help us test and confirm that all
>         is well! I will create a bug to capture the feedback.
> 
>         It's important for us that the service is stable during the
>         upcoming holidays. If we are not successful on Monday, we will
>         revert to the current version and we won't try this again until
>         the new year!
> 
>         Thanks, and please don't hesitate to reach out if you have any
>         questions!
> 
>         Have a great weekend everyone!
> 
>         On Thu, Dec 10, 2020 at 10:33 AM Christopher Guindon
>         <chris.guindon@xxxxxxxxxxxxxxxxxxxxxx
>         <mailto:chris.guindon@xxxxxxxxxxxxxxxxxxxxxx>> wrote:
> 
>             Hi All,
> 
>             Here's a quick update for the ECA upgrade:
>             https://www.chrisguindon.com/post/eca-validation-update-gerrit/
> 
>             We went live with our new plugin but before the end of our
>             day in Ottawa, I decided to revert back to our previous
>             version because the plugin was requiring project committers
>             to include their sign-off-by footer.
> 
>             Unfortunately, the revert was not properly taken into
>             account by Gerrit. MikaëlBarbaro was able to fix that
>             problem this morning.
> 
>             We are hoping to re-deploy our new plugin before the end of
>             the week but if that's not possible, will re-schedule the
>             update for early January.
> 
>             Please let me know if you have any questions!
> 
> 
>             On Wed, Dec 9, 2020 at 10:38 PM Wayne Beaton
>             <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx
>             <mailto:wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>> wrote:
> 
>                 The webdev team is working on it.
> 
>                 https://bugs.eclipse.org/bugs/show_bug.cgi?id=569607
> 
>                 The short term work around is to "sign-off-by" your commits.
> 
>                 Wayne
> 
>                 On Wed, Dec 9, 2020 at 9:03 PM Jonah Graham
>                 <jonah@xxxxxxxxxxxxxxxx <mailto:jonah@xxxxxxxxxxxxxxxx>>
>                 wrote:
> 
>                     Hi folks,
> 
>                     Not sure if this is only me, but Gerrit ECA check is
>                     reporting me as not a committer. I have
>                     raised https://github.com/EclipseFdn/gerrit-eca-plugin/issues/31
> 
>                     If you are also so affected you can workaround the
>                     issue by signing off your commits as if you were a
>                     contributor.
> 
>                     This problem does not seem to affect stuff once your
>                     code is in gerrit, just the pushing to gerrit.
> 
>                     Jonah
> 
> 
>                     ~~~
>                     Jonah Graham
>                     Kichwa Coders
>                     www.kichwacoders.com <http://www.kichwacoders.com>
>                     _______________________________________________
>                     cross-project-issues-dev mailing list
>                     cross-project-issues-dev@xxxxxxxxxxx
>                     <mailto:cross-project-issues-dev@xxxxxxxxxxx>
>                     To unsubscribe from this list, visit
>                     https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
> 
> 
> 
>                 -- 
> 
>                 Wayne Beaton
> 
>                 Director of Open Source Projects | Eclipse Foundation, Inc.
> 
>                 Join us at our virtual event: EclipseCon 2020
>                 <https://www.eclipsecon.org/2020>- October 20-22
> 
>                 _______________________________________________
>                 cross-project-issues-dev mailing list
>                 cross-project-issues-dev@xxxxxxxxxxx
>                 <mailto:cross-project-issues-dev@xxxxxxxxxxx>
>                 To unsubscribe from this list, visit
>                 https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
> 
> 
> 
>             -- 
>             Christopher Guindon
>             Manager, Web Development | Eclipse Foundation, Inc.
>             Eclipse Foundation: The Platform for Open Innovation and
>             Collaboration
>             Twitter: @chrisguindon
> 
> 
> 
>         -- 
>         Christopher Guindon
>         Manager, Web Development | Eclipse Foundation, Inc.
>         Eclipse Foundation: The Platform for Open Innovation and
>         Collaboration
>         Twitter: @chrisguindon
> 
> 
> 
>     -- 
>     Christopher Guindon
>     Manager, Web Development | Eclipse Foundation, Inc.
>     Eclipse Foundation: The Platform for Open Innovation and Collaboration
>     Twitter: @chrisguindon
>     _______________________________________________
>     cross-project-issues-dev mailing list
>     cross-project-issues-dev@xxxxxxxxxxx
>     <mailto:cross-project-issues-dev@xxxxxxxxxxx>
>     To unsubscribe from this list, visit
>     https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
> 
> 
> _______________________________________________
> cross-project-issues-dev mailing list
> cross-project-issues-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
> 

-- 
Frederic Gurr
Release Engineer | Eclipse Foundation Europe GmbH

Berliner Allee 47, D-64295 Darmstadt
Handelsregister: Darmstadt HRB 92821
Managing Directors: Gaël Blondelle, Mike Milinkovich