Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cross-project-issues-dev] Signed-off-by For Committers

In a recent review, a discussion came up about whether committers to a
project should be adding the 'Signed-off-by' header to their commits on
that same project.

I'm assuming it's mandatory for all non-committers to a project as
Gerrit will certainly reject the commit. However, I see plenty of
changes by committers (even recently) that do not contain it so Gerrit
is definitely not enforcing it in this case. Is it implicit from the
committer agreement one would have on file ? Is there any reason to
include one anyways ? (eg. stats being collected from it
that we wouldn't appear in). I could definitely see the argument for
saving a line in the log messages.

Roland Grunberg

Back to the top