|Re: [cross-project-issues-dev] SimRel - direct push to master has been disabled|
Normally you would use the Gerrit review link to finish the
processing. E.g., for the last commit I used this link:
After the initial commit, I waited for the build to finish so
that CI Bot (one of the automatic reviewers) adds a +1. That
takes about 5 minutes. Then I used the Reply... (or the Review +2
button, which will be there after the successful build) to make it
possible to "Submit" the changes to master, i.e., the Submit
button will be there once all the reviewers (CI Bot and you) have
voted the changes up to the necessary level.
So the chain of events looks like this in the review:
After submitting, when I do a pull on the repo, my changes are pulled and the repo is up-to-date (no longer one commit behind master).
I believe a non-dilegent user could remove CI Bot from the review
to submit their changes even when those did not pass the
aggregation build but it appears to me that there really is no
good reason to allow direct push to master as a way to completely
bypass the CI Bot review.
On 12.11.2018 22:04, Ed Willink wrote:
Back to the top