[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cross-project-issues-dev] TableTree Removal Will Break Some EMF APIs

As you may or may not be aware, there are plans to remove org.eclipse.swt.custom.TableTree:

 https://bugs.eclipse.org/bugs/show_bug.cgi?id=475833

And hence plans to remove org.eclipse.jface.viewers.TableTreeViewer:

 https://bugs.eclipse.org/bugs/show_bug.cgi?id=540481

This also affects EMF. Mostly I just need to delete these long deprecated classes:

org.eclipse.emf.common.ui/src/org/eclipse/emf/common/ui/celleditor/ExtendedTableTreeEditor.java
org.eclipse.emf.common.ui/src/org/eclipse/emf/common/ui/viewer/ExtendedTableTreeViewer.java
org.eclipse.emf.edit.ui/src/org/eclipse/emf/edit/ui/celleditor/AdapterFactoryTableTreeEditor.java

Presumably no one is using those. But they are used by org.eclipse.emf.mapping.presentation.MappingEditor.OverviewViewer.

I was tempted to just remove org.eclipse.mapping.ui (and projects that subclass it) but it was brought to my attention that those are being used:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=540481#c24

I can change this class to subclass TreeViewer, but that breaks API. I'm never happy breaking APIs, but I doubt anyone is directly using this class such that they would see the API changes.

If you have any concerns, about these deletions and API-breakages please comment on:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=540539