Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Enforce Gerrit for Simrel?

I would not say "stability/quality" has improved (depending on what that means), but it is clear that it avoids "breaking HEAD" of the '' repository. And that is great.

It is already 'required' that contributors "go though Gerrit" ... but it is allowed that the 'review/validation' can be skipped, if "refs/heads/master" used instead of "refs/for/master".

But I myself would not like to see it *required* to go through "refs/for/master".  I think most already do go through "refs/for/master" and the few times they do not, I would assume they have a good reason for it.

Can you point out (or monitor for) cases where people go directly to "refs/heads/master" and it causes problems?


From:        Mickael Istria <mistria@xxxxxxxxxx>
To:        Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>,
Date:        01/07/2016 07:06 AM
Subject:        [cross-project-issues-dev] Enforce Gerrit for Simrel?
Sent by:        cross-project-issues-dev-bounces@xxxxxxxxxxx

Hi all,

Gerrit for SimRel has been widely used by many projects and the validation checks that come with Simrel have successfully caught a bunch of issues before the had the opportunity to break the Simultaneous Release. Gerrit and Code-Review can have an incredible effect on software quality, many projects and teams enforce it with success. I don't have metrics, but maybe David can say whether he felt a noticeable improvement in stability/quality since the inception of Gerrit a few months ago?

I believe it's the right time to start considering enforcing Gerrit usage for SimRel: a first implementation would be to have committers push to refs/for/master instead of master, and would either be reviewed by someone else, or review themselves their contribution. The Hudson validation job triggers automatically on any contribution and gives a vote if the contribution is breaking the build.

What do you think?

Mickael Istria
Eclipse developer at
JBoss, by Red Hat
My blog - My Tweets_______________________________________________
cross-project-issues-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

Back to the top