Re: [cross-project-issues-dev] 1000 line limit for contributions

[Ed Merks <ed.merks@xxxxxxxxx>]

Recall that this was increased from 250 to 1000 not so long ago.  I 
wasn't able to push the IP committee beyond that.  People working for an 
organization that has a corporate representative on the board could ask 
that representative to raise this issue at a board meeting.  I think 
that would carry more weight than me personally asking for a further 
increase.


On 19/11/2015 11:00 AM, Ed Willink wrote:
> Hi
>
> Presumably you put tests in a separate plugin, so splitting off the 
> tests as a separate contribution gets you twice the limit with minimal 
> effort.
>
> Perhaps a 10000 line limit might be appropriate for non-deliverable 
> code such as tests and build tools.
>
>     Regards
>
>         Ed Willink
>
>
>
> On 19/11/2015 09:49, Sievers, Jan wrote:
> > Hi,
> >
> > in the course of
> >
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=477328
> >
> >
> > we had a contribution that slightly exceeded 1000 lines and thus 
> > needed a CQ.
> > It took about one month to review it.
> >
> > I am sure the legal team does its very best to keep up with the load, 
> > so the following is in no way a criticism of the
> > people who actually do the legal review.
> >
> > Rather take it as food for thought to whoever set up this rule.
> >
> > IMHO the 1000 line rule is effectively setting the wrong incentives 
> > for a thriving opensource project.
> >
> > Here is why I think so:
> >
> >
> > The most diligent contributors add a lot of tests to their patch to 
> > prove it works.
> > This is a good thing and we actively encourage contributors to 
> > thoroughly test.
> > Test code can easily outweigh productive code being tested in terms 
> > of LOC.
> > However this means the most diligent contributors, i.e. the ones you 
> > want to attract, are more likely to hit the 1000 line limit.
> > Instead of thanking them for their hard work, we effectively punish 
> > them with an extra month or more wait time before their patch can be 
> > merged.
> > Apart from that, the 1000 line limit seems arbitrary to me because 
> > technically you can split up any commit into any number
> > of smaller commits below the 1000 line limit.
> >
> > Best Regards,
> > Jan
> >
> >
> >
> >
> > _______________________________________________
> > cross-project-issues-dev mailing list
> > cross-project-issues-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or 
> > unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
>
> _______________________________________________
> cross-project-issues-dev mailing list
> cross-project-issues-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev