Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] How to set Review/Verified flags on already merged gerrit changesets

Hi Fred,

I personally would not try to put the Gerrit reviews into a correct state. The truth is still the Git repo and if you pushed a change directly to Git that is good enough IMHO as it should contain the original author. 

I would include a comment in the Gerrrit review similar to "Pushed directly to the Git repo with [link to the commit". In platform dev we also try to include a link to the Git commit into the Bug report for reference, i.e., I would update https://bugs.eclipse.org/bugs/show_bug.cgi?id=445404 with the corresponding weblink to the commit, i.e. http://git.eclipse.org/c/m2e-wtp/org.eclipse.m2e.wtp.git/commit/?id=40112e8718567bbf5ca3e533f453cd18ce4c90b6

Best regards, Lars

2014-10-13 18:20 GMT+02:00 Fred Bricon <fbricon@xxxxxxxxx>:
Hi,

so I kind of f*ed up pushing a couple gerrit changesets directly from my local repo , instead of using the webapp and its brilliant and so intuitive UI (sarcasm included) and the Review/Verified flags are not set (see https://git.eclipse.org/r/#/q/status:merged+project:m2e-wtp/org.eclipse.m2e.wtp,n,z)
I haven't found a way to set these flags from the UI once the changesets have already been merged. Anyone knows how to do that? Should I open a bug to the webmasters @ eclipse.org?

Thanks,

Fred Bricon

--
"Have you tried turning it off and on again" - The IT Crowd

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev


Back to the top