I opened a separate bug, in case this is a different issue. Assigned to Equinox for now. Simple repro attached.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=443614
Thanks,
- Konstantin
From: cross-project-issues-dev-bounces@xxxxxxxxxxx [mailto:cross-project-issues-dev-bounces@xxxxxxxxxxx] On Behalf Of Thomas Watson
Sent: Tuesday, September 09, 2014 7:23 AM
To: Cross project issues
Subject: Re: [cross-project-issues-dev] Apparent Luna SR1 regression in build failure reporting
OK, please track the issue and post the repro with bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=443595
Tom
From: "Konstantin Komissarchik" <konstantin.komissarchik@xxxxxxxxxx>
To: "'Cross project issues'" <cross-project-issues-dev@xxxxxxxxxxx>
Date: 09/09/2014 08:57 AM
Subject: Re: [cross-project-issues-dev] Apparent Luna SR1 regression in build failure reporting
Sent by: cross-project-issues-dev-bounces@xxxxxxxxxxx
Here is how we are calling into PDE Build. I don’t see any references to osgi.framework.useSystemProperties.
<java classname="org.eclipse.core.launcher.Main"
fork="true" failonerror="true" maxmemory="${java.maxmemory}">
<classpath>
<fileset dir="${bootstrap.platform}/plugins">
<include name="**/org.eclipse.equinox.launcher_*.jar"/>
</fileset>
</classpath>
<arg line="-clean"/>
<arg line="-application org.eclipse.ant.core.antRunner"/>
<arg line="-data ${build.dir}/pde/workspace"/>
<arg line="-configuration ${build.dir}/pde/configuration"/>
<arg line="-buildfile ${.pdeBuildDir}/scripts/build.xml"/>
<arg value="-DtopLevelElementId=@{feature.id}"/>
<arg value="-DarchivePrefix=eclipse"/>
<arg value="-DbaseLocation=@{eclipse.install.dir}"/>
<arg value="-DbuildDirectory=@{root.dir}"/>
<arg value="-Dbuilder=${build.dir}/pde/builder"/>
<arg value="-DcollectingFolder=collecting"/>
<arg value="-DbuildId=@{build.id}"/>
<arg value="-DbuildType=I"/>
<arg value="-DbuildLabel=build"/>
<arg value="-DROOT_RELENG_DIR=@{root.releng.dir}"/>
<arg value="-DforceContextQualifier=@{build.id}"/>
<arg value="-DgenerateFeatureVersionSuffix=false"/>
<arg value="-DindividualSourceBundles=true"/>
<arg value="-DallowBinaryCycles=true" />
<arg value="-DcompilerArg=${pde.build.compiler.arg}"/>
<arg value="-DJ2SE-1.4=${java.14.system.classpath}"/>
<arg value="-DJavaSE-1.6=${java.16.system.classpath}"/>
<arg value="-DJavaSE-1.7=${java.17.system.classpath}"/>
<java-args/>
</java>
I will work on a stand-alone repro today.
- Konstantin
From: cross-project-issues-dev-bounces@xxxxxxxxxxx [mailto:cross-project-issues-dev-bounces@xxxxxxxxxxx] On Behalf Of Thomas Watson
Sent: Tuesday, September 09, 2014 6:41 AM
To: Cross project issues
Subject: Re: [cross-project-issues-dev] Apparent Luna SR1 regression in build failure reporting
Konstantin
I put a fix into master for the 4.5 Eclipse I-Build that should happen today (we need to respin for another issue). Would you be able to test with this I-Build once it is done to see if it fixes the issue? Then we can consider backporting to Luna.
Tom
From: Thomas Watson/Austin/IBM@IBMUS
To: Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Date: 09/09/2014 07:35 AM
Subject: Re: [cross-project-issues-dev] Apparent Luna SR1 regression in build failure reporting
Sent by: cross-project-issues-dev-bounces@xxxxxxxxxxx
This sounds similar to https://bugs.eclipse.org/bugs/show_bug.cgi?id=436073
There have been some changes to Equinox for SR1 dealing with system properties. I am wondering somehow the system property osgi.framework.useSystemProperties=true is being set before invoking the framework from the build.
Tom
From: "Konstantin Komissarchik" <konstantin.komissarchik@xxxxxxxxxx>
To: "'Cross project issues'" <cross-project-issues-dev@xxxxxxxxxxx>
Date: 09/08/2014 10:34 PM
Subject: Re: [cross-project-issues-dev] Apparent Luna SR1 regression in build failure reporting
Sent by: cross-project-issues-dev-bounces@xxxxxxxxxxx
Anyone? We are down to the wire here and it’s looking like Luna SR1 will be useless as a build driver unless there is a last-minute fix, since we can’t depend on it failing the build correctly.
- Konstantin
From: cross-project-issues-dev-bounces@xxxxxxxxxxx [mailto:cross-project-issues-dev-bounces@xxxxxxxxxxx] On Behalf Of Konstantin Komissarchik
Sent: Monday, September 08, 2014 10:01 AM
To: 'Cross project issues'
Subject: [cross-project-issues-dev] Apparent Luna SR1 regression in build failure reporting
We are seeing a serious regression in Luna SR1 (tested with platform RC3) where PDE build does not report a process failure code when the build fails. This causes any invoking build process (such as Ant) to not detect a failure and continue.
Just confirmed that this works correctly if Luna is used to drive the build instead of Luna SR1.
I am not sure if the regression is in the launcher or in the PDE build.
Is anyone else seeing this?
Thanks,
- Konstantin
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev _______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev _______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
