Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] 6 month release cycle

You missed the second half of my writeup…


From: cross-project-issues-dev-bounces@xxxxxxxxxxx [mailto:cross-project-issues-dev-bounces@xxxxxxxxxxx] On Behalf Of Mickael Istria
Sent: Tuesday, July 09, 2013 8:43 AM
To: cross-project-issues-dev@xxxxxxxxxxx
Subject: Re: [cross-project-issues-dev] 6 month release cycle


On 07/09/2013 05:24 PM, Konstantin Komissarchik wrote:

I don’t see why manual Gerrit reviews would be desirable. Since the only goal here is to ensure that aggregation doesn’t break, a successful aggregation pass is enough to prove that the contribution is good.

A successful aggregation pass is enough to ensure build works once. The Jenkins Gerrit plugin would provide that.
A human review would help to ensure that the contribution is good (sustainable URL, stable content, conformance to guidelines).

Code review would decrease the amount of failed aggregation builds (because bad URLs would have more difficulties to get in) and would make contributors more aware of what is expected from them.
Code review FTW! and

Mickael Istria
Eclipse developer at JBoss, by Red Hat
My blog - My Tweets

Back to the top