| RE: [corona-dev] ReposityAdapter |
|
I have a couple of comments: I think content-type should not be specific to I think something more like: http://www.eclipse.org/corona/contentTypes/EclipseProjectCVSModule
or more simply http://www.eclipse.org/corona/contentTypes/CVSModule I don’t understand why it is better for resource-subset
to be a repository-connection-parameter, this provides less information. I agree with the unique URI in Glenn Everitt From: Changes include: uri is a unique URI in content-type is a unique URI access-type is added, it is a unique URI meaning cvs (in contrast to
subversion, e.g.) parameters define connection configuration. The implementation of
adapter for (eclipseProject, CVS) needs to interpret the parameters. resource-subset is changed to a connection-parameter. repository name corresponds to workbench project name (it is necessary
for the demo, but may be changed in the future) <repository-descriptor
name="org.eclipse.corona.model.container" uri="http://www.eclipse.org/corona/incubator/org.eclipse.corona.model/container" content-type="http://www.eclipse.org/corona/contentTypes/workbenchProjectContent"> <description>The first cut at CVS
Repository Definition</description> <repository-configurations
default-configuration-name="CoronaCVSRepositoryConfiguration" >
<repository-configuration name="CoronaCVSRepositoryConfiguration">
<repository-connection-parameters
access-type="http://www.eclipse.org/corona/accessTypes/cvs">
<repository-connection-parameter name="Method"
value="pserver" />
<repository-connection-parameter name="Host"
value="206.191.52.50" />
<repository-connection-parameter name="User" value="
anonymous" />
<repository-connection-parameter name="RepositoryPath"
value="/home/technology" />
<repository-connection-parameter name="Module"
value="org.eclipse.corona/incubator/org.eclipse.corona.model.container"
/>
<repository-connection-parameter name="CVS-TAG"
value="HEAD" />
</repository-connection-parameters>
</repository-configuration> </repository-configurations> </repository-descriptor> Pawel -----Original Message----- Please update the sample the way you think makes sense and re-post it
to the newsgroup. Thanks Glenn Everitt -----Original Message----- From: [mailto: Sent: Tuesday, August 01, 2006 5:22 AM To: Subject: RE: [corona-dev] ReposityAdapter We can't limit the format of connection parameters to Eclipse
format (File -> Import/Export), as a repository is a general concept. It is repository adapter that knows how to operate on a repository. Checking out a repository is certainly UI specific, so I
wouldn't assign this functionality to RepositoryAdaptor. UI functions create something like RepositoryUIHandler that manages UI of a repository (supplies icon, checks out, displays view). The handler is a general case of RepositoryDescriptorViewer and RepositoryAdapterEditorViewer that are mentioned on the wiki. In the example you gave, host,
port and connection type of CVS are defined in URI field. The information should rather be defined in connection parameters. Pawel -----Original Message----- From: [mailto: Sent: Tuesday, August 01, 2006 10:55 AM To: Subject: Re: [corona-dev] ReposityAdapter An adapter can still use Eclipse implementations to perform check out operation. If we were to do a check out without adapter then I think we
should store connection parameters in the same way as does it
"File > (Export | Import) > Team > Team Project Set". Then we could
do it in generic way, as team import does. Otherwise we have to provide again some extra logic for each type of repository. Marcin >>Pawel's was intending to ask if there is going to be a method > "checkOut()" in our artifact respository adapter. This
method is > needed to make >a "Join story" where you join a > then all Workbench projects are checked out from CVS. > > A question that doesn't have a simple answer. > > The IRepositoryAdapter does have a fetchResource which could be
used > for function. The implementation of the IRepositoryAdapter for a
CVS > Repository would implement the fetchResource method using the cvs > checkout. > > There is a bigger issue which is when to use IRepositoryAdapter
and > when to use the native interface to a Repository. My thinking was
that > we would reuse as much eclipse client side code as possible.
Eclipse > already has a way to checkout multiple Workbench Projects from CVS
and > I think it would make sense to reuse that code and not
re-implement > this code in a RepositoryAdapter. > > First let try to decide what the Repository configuration for CVS > would look like. Here is my guess: > > <repository-descriptor > name="CVS.incubator.org.eclipse.corona.model.container" > uri="cvs:pserver:anonymous@206.191.52.50/home/technology/org.eclipse.cor ona/incubator/org.eclipse.corona.model/container" > content-type="eclipse-project" > > > <description>The first cut at CVS Repository Definition</description> > > <repository-configurations >
default-configuration-name="CoronaCVSRepositoryConfiguration" > > > <repository-configuration
name="CoronaCVSRepositoryConfiguration"> > > <repository-connection-parameters> > > <repository-connection-parameter
name="RepositoryPath" > value="/home/technology" /> > > <repository-connection-parameter name="Module" > value="org.eclipse.corona/incubator/org.eclipse.corona.model.container" /> > > <resource-subset type="CVS-TAG"
selection-criteria="HEAD" /> > > </repository-connection-parameters> > > </repository-configuration> > > </repository-configurations> > > </repository-descriptor> > > It seems like the RepositoryAdapter fetch method would find the > repository-descriptor for an eclipse project and then use the > repository-connection-parameters to make calls to the Eclipse Team
> plugin for CVS to do the checkout. > > The other issue is we would like to use the cvs userid and
password > defined in the Eclipse Workbench that is issuing the > ProjectContainerOpen. Rather than, having the userid in > repository-descriptor uri we would use the userid specified in the
CVS > Repositories View | Properties. We need to determine if we can
access > the userid and password value through the Eclipse Team interface.
This > capability isn't required for demo. > > The contents of this e-mail are intended for the named addressee
only. > It contains information that may be confidential. Unless you are
the > named addressee or an authorized designee, you may not copy or use
it, > or disclose it to anyone else. If you received it in error please > notify us immediately and then destroy it. > >----------------------------------------------------------------------- - > >_______________________________________________ >corona-dev mailing list >corona-dev@xxxxxxxxxxx >https://dev.eclipse.org/mailman/listinfo/corona-dev > > The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please
notify us immediately and then destroy it. _______________________________________________ corona-dev mailing list corona-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/corona-dev The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please
notify us immediately and then destroy it. _______________________________________________ corona-dev mailing list corona-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/corona-dev The contents of this e-mail are intended for the named addressee only.
It contains information that may be confidential. Unless you are the named
addressee or an authorized designee, you may not copy or use it, or disclose it
to anyone else. If you received it in error please notify us immediately and
then destroy it. _______________________________________________ corona-dev mailing list corona-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/corona-dev The contents of this e-mail are intended for the named addressee only.
It contains information that may be confidential. Unless you are the named
addressee or an authorized designee, you may not copy or use it, or disclose it
to anyone else. If you received it in error please notify us immediately and
then destroy it. |