Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [concierge-dev] How to set Image from Bundle-Icon header where bundle is in INSTALLED state
Hi Ladislav,

now I understand where the problem comes.

Ladislav is trying to call aBundle.getEntry() in a Bundle Listener.

The method installNewBundle() is implemented as:
...
// notify the listeners
notifyBundleListeners(BundleEvent.INSTALLED, bundle, context.getBundle());
bundle.install();
...

The bundle will be added to the internal list bundleID_bundles in install() method, which is called AFTER firing the Bundle.INSTALLED event.

synchronized (framework) {
  framework.bundles.add(this);
  framework.bundleID_bundles.put(new Long(getBundleId()), this);
  framework.symbolicName_bundles.insert(
  currentRevision.getSymbolicName(), this);
  framework.location_bundles.put(location, this);
}

But: The openConnection method indirectly used by getEntry() and loading content from URL makes a lookup on internal list 

final BundleImpl bundle = (BundleImpl) ConciergeURLStreamHandlerFactory.this.frameworkInstance.bundleID_bundles.get(bundleId);
if (bundle == null) {
  throw new IllegalStateException("Bundle for URL " + u + " can not be found");
}

This exception will be raised and the bundle:/1.0/icon.png can NOT be resolved to a bundle, as list does not yet contain the if of installed bundle.

Question to Jan/Tim:

It is valid to make calls on a bundle in a BundleEventListener? My assumption would be yes.
In this case parts of bundle.install() code has to be moved into Constructor (there is already a comment in code on that).

Bye, Jochen



On Fri, Dec 5, 2014 at 1:37 PM, Ladislav Török <ltorokrl@xxxxxxxxx> wrote:
My modified snippet:

final BundleContext bundleContext = framework.getBundleContext();

            bundleContext.addBundleListener((BundleEvent event) -> {
                Bundle bundle = event.getBundle();
                String resolvedBundleEventType = resolveBundleEventType(event.getType());
                System.out.println(bundle.getSymbolicName() + " -> " + resolvedBundleEventType);

                if (resolvedBundleEventType == "INSTALLED") {
                    //Image bundleImage = getBundleIcon(bundle);

                    Map<String, String> headers = (Map<String, String>) bundle.getHeaders();
                    for (String key : headers.keySet()) {
                        System.out.println(key + ": " + headers.get(key));
                    }

                    Image bundleImage = null;
                    URL entry = bundle.getEntry(bundle.getHeaders().get(ICON_HEADER));
                    System.out.println(entry.toString());
                    if (entry != null) {
                        String s = getContentFromUrl(entry);
                        bundleImage = new Image(entry.toString());
                    }

                    if (bundleImage != null) {
                        ImageView bundleImageView = new ImageView(bundleImage);
                        bundleImageView.setX(30);
                        bundleImageView.setY(100);
...

I get now exception:

java.lang.IllegalStateException: Bundle for URL bundle://1.0/icon.png can not be found
    at org.eclipse.concierge.Concierge$ConciergeURLStreamHandlerFactory$1.openConnection(Concierge.java:3088)
    at java.net.URL.openConnection(URL.java:972)
    at com.javafx.experiments.dukepad.starter.StarterApplication.getContentFromUrl(StarterApplication.java:217)
    at com.javafx.experiments.dukepad.starter.StarterApplication.lambda$startOSGi$30(StarterApplication.java:138)
    at com.javafx.experiments.dukepad.starter.StarterApplication$$Lambda$99/670507401.bundleChanged(Unknown Source)
    at org.eclipse.concierge.Concierge.notifyBundleListeners(Concierge.java:3473)
    at org.eclipse.concierge.Concierge.installNewBundle(Concierge.java:3825)
    at org.eclipse.concierge.Concierge.installNewBundle(Concierge.java:3784)
    at org.eclipse.concierge.Concierge$BundleContextImpl.installBundle(Concierge.java:4376)
    at com.javafx.experiments.dukepad.starter.StarterApplication.lambda$startOSGi$32(StarterApplication.java:196)
    at com.javafx.experiments.dukepad.starter.StarterApplication$$Lambda$101/477397791.run(Unknown Source)
    at com.javafx.experiments.dukepad.starter.StarterApplication.lambda$runNextStartupTask$33(StarterApplication.java:297)
    at com.javafx.experiments.dukepad.starter.StarterApplication$$Lambda$102/361019598.run(Unknown Source)
    at com.sun.javafx.application.PlatformImpl.lambda$null$169(PlatformImpl.java:295)
    at com.sun.javafx.application.PlatformImpl$$Lambda$48/1163811663.run(Unknown Source)
    at java.security.AccessController.doPrivileged(Native Method)
    at com.sun.javafx.application.PlatformImpl.lambda$runLater$170(PlatformImpl.java:294)
    at com.sun.javafx.application.PlatformImpl$$Lambda$47/1232367853.run(Unknown Source)
    at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
    at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
    at com.sun.glass.ui.win.WinApplication.lambda$null$144(WinApplication.java:101)
    at com.sun.glass.ui.win.WinApplication$$Lambda$36/1161082381.run(Unknown Source)
    at java.lang.Thread.run(Thread.java:745)
BUILD STOPPED (total time: 18 seconds)

java.lang.IllegalStateException, but bundle is not in UNINSTALLED state.


2014-12-05 13:22 GMT+01:00 Jochen Hiller <jo.hiller@xxxxxxxxxxxxxx>:
Hi Ladislav,

On Fri, Dec 5, 2014 at 12:54 PM, Ladislav Török <ltorokrl@xxxxxxxxx> wrote:
sorry, but I made a mistake:
bundle.getEntry() in INSTALLED state returns of course: bundle://1.0/icon.png // after bundle.getEntry( "Bundle-Icon").toString()

Hmm, seems OK.
Can you add code to check whether loading content from URL does work?
E.g do same like in TestUtils.getContentFromUrl(getEntry().toString())

It may be that this code
new Image(entry.toString());

does not work correct in JavaFX.
But again, no idea why it does behave different in INSTALLED and RESOLVED state.

Bye, Jochen

 

2014-12-05 12:51 GMT+01:00 Ladislav Török <ltorokrl@xxxxxxxxx>:
bundle.getHeaders() in INSTALLED state returns :

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.9.2
Bundle-Activator: sk.ltorok.bundles.Bundle1
Created-By: 1.8.0_40-ea-b15 (Oracle Corporation)
Bundle-ManifestVersion: 2
Import-Package: org.osgi.framework
Bundle-SymbolicName: sk.ltorok.bundles
Bundle-Name: sk.ltorok.bundles
Bundle-Version: 1.0.0
Bundle-Icon: /icon.png

and bundle.getEntry() in INSTALLED state returns:
bundle://1.0/VideoPlayer.png // after bundle.getEntry( "Bundle-Icon").toString()

2014-12-05 11:19 GMT+01:00 Jochen Hiller <jo.hiller@xxxxxxxxxxxxxx>:
Hi Ladislav,

On Fri, Dec 5, 2014 at 10:52 AM, Ladislav Török <ltorokrl@xxxxxxxxx> wrote:
I want in INSTALLED state of bundle only create ImageView (in JavaFX) - It will represent bundle for my using.
After click on ImageView (icon) bundle is call bundle.start() -> ACTIVE state.

OK I see. Sounds reasonable

 
Present snippet is ok but only in RESOLVED state of bundle, at INSTALLED state of bundle ImageView dont have picture.

URL entry = bundle.getEntry(bundle.getHeaders().get(ICON_HEADER));

What does bundle.getHeaders() and bundle.getEntry() return in INSTALLED state? Maybe the property is defined wrong.
You may have to specify the name of entry with leading slash, e.g. "/myicon.jpg"?
(OK this is no argument why it is working in RESOLVED state).

Bye, Jochen

 
I don't know where is problem.

2014-12-05 8:38 GMT+01:00 Jochen Hiller <jo.hiller@xxxxxxxxxxxxxx>:
Hi Ladislav,

every bundle has its own state based on OSGi bundle life cycle.

INSTALLED means that is has been installed into a framework. This does not necessarily mean that it will work.
When bundle will be started, it goes first to RESOLVED state when all dependencies can be resolved, or stay in INSTALLED state when it can not be resolved. It will go to ACTIVE state when everything is fine.

To be honest there are more variations on that (intermediate states like STARTING, LAZY mode ...). For more details see OSGi R5 spec chapter 4.3.

Whether a bundle can be used in INSTALLED state or only in RESOLVED/ACTIVE state depends on your requirements.
If no Java classes are needed (which seems to be the case when you want to get the Manifest header for a Bundle-Icon) you can also try to get a resource via bundle.getEntry(). In OSGi spec 10.1.6.17 it will be stated that this should be possible. Only when bundle has been uninstalled it will raise an IllegalStateException.

I will check how Concierge will behave in such a situation.

But anyway: why do you want to use the bundle in INSTALLED state only? There are very few situations where this makes sense (e.g. just providing static content).

Bye, Jochen






On Fri, Dec 5, 2014 at 8:12 AM, Ladislav Török <ltorokrl@xxxxxxxxx> wrote:
Here is my snippet:

import javafx.scene.image.Image;
import javafx.scene.image.ImageView;
...

private static final String ICON_HEADER = "Bundle-Icon";
...

final BundleContext bundleContext = framework.getBundleContext();

            bundleContext.addBundleListener((BundleEvent event) -> {
                Bundle bundle = event.getBundle();
                String resolvedBundleEventType = resolveBundleEventType(event.getType());
                System.out.println(bundle.getSymbolicName() + " -> " + resolvedBundleEventType);

                if (resolvedBundleEventType == "INSTALLED") {
                    Image bundleImage = null;
                    URL entry = bundle.getEntry(bundle.getHeaders().get(ICON_HEADER));
                    if (entry != null) {
                        bundleImage = new Image(entry.toString());
                    }

                    if (bundleImage != null) {
                        ImageView bundleImageView = new ImageView(bundleImage);
                        bundleImageView.setX(30);
                        bundleImageView.setY(100);
                        ((Group) scene.getRoot()).getChildren().add(bundleImageView);
                    }
                }
            });

If I replace the line
if (resolvedBundleEventType == "INSTALLED") {
to
if (resolvedBundleEventType== "RESOLVED") {
then all is ok.

There is no way to do this in INSTALLED state of bundle?

_______________________________________________
concierge-dev mailing list
concierge-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/concierge-dev


_______________________________________________
concierge-dev mailing list
concierge-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/concierge-dev


_______________________________________________
concierge-dev mailing list
concierge-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/concierge-dev


_______________________________________________
concierge-dev mailing list
concierge-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/concierge-dev



_______________________________________________
concierge-dev mailing list
concierge-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/concierge-dev



Back to the top