Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [che-dev] DTO behavior change

I don't think that it's possible to do that in a reasonable amount of time.
The reason is that it used in DtoFactory.java  that is used in a static way
and standard configuration option is not available to it. And since we are not GA yet
I assume that we can do that change without much harm.

On Fri, Jun 14, 2019 at 10:32 AM Florent Benoit <florent@xxxxxxxxxx> wrote:
yes, it's just that we don't know all possible clients consuming the API

On Fri, Jun 14, 2019 at 9:27 AM Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:


On Fri, Jun 14, 2019 at 10:22 AM Florent Benoit <florent@xxxxxxxxxx> wrote:
Hello Sergii,

Is there a flag available for a couple of releases to get back to the previous behaviour in cases some clients have issues ?
No. We are not planned to do that. Are there any reasonable arguments to believe that is really needed?

Florent

On Fri, Jun 14, 2019 at 8:14 AM Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:
Hello

I would like to share a note about the change in DTO behavior on Che master side.

Previously in during DTO serialization, we put everything to the output including
empty collections/fields. At this moment we are not able to identify the concrete reason why we did this way and not the opposite.

This behavior brings to us some difficulties when we tried to add devfile schema validation in our REST API.
So we decided to rethink this behavior again.  As a result, we think that it makes sense to revert this behavior and do not serialize empty collections/fields. That will allow reducing the size of result json. As a side effect all clients (most of them already doing that)
has to check optional field != null before doing any operation with it.

Corresponding PR https://github.com/eclipse/che/pull/13515

--

Sergii Kabashniuk

Principal Software Engineer, DevTools 

Red Hat Ukraine

skabashniuk@xxxxxxxxxx    

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

Sergii Kabashniuk

Principal Software Engineer, DevTools 

Red Hat Ukraine

skabashniuk@xxxxxxxxxx    

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev
_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/che-dev


--

Sergii Kabashniuk

Principal Software Engineer, DevTools 

Red Hat Ukraine

skabashniuk@xxxxxxxxxx    


Back to the top