Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
APPLIED: RE: [cdt-patch] Patch: pulls code in managed project wizard intoprotected methods

Applied with some minor changes.  I made getSelectedConfigurations()
public rather than protected since we already have a public
getSelectedProjectType() and it made sense to me that the visibility
should match.

I'm open to refactorings so long as we're not doing major breakage of
API.  Adding new API like this is no big deal as no one is using the new
APIs and thus can't get euchred by changes.  Keep in mind though that
you're running out of time on 3.0...

Thanks,

___________________________________________
 
Chris Recoskie
Software Designer
IDE Frameworks Group
Texas Instruments, Toronto
 
 

> -----Original Message-----
> From: cdt-patch-bounces@xxxxxxxxxxx
[mailto:cdt-patch-bounces@xxxxxxxxxxx]
> On Behalf Of Lott, Jeremiah
> Sent: Thursday, June 30, 2005 3:04 PM
> To: cdt-patch@xxxxxxxxxxx
> Subject: [cdt-patch] Patch: pulls code in managed project wizard
> intoprotected methods
> 
> This patch takes some code from the doRun method of the managed
project
> wizard and moves it into protected methods.  We have a custom wizard
for
> managed projects, and if this patch is accepted it would make things
> much easier for us to extend.  This is not intended to change the
> functionality of the wizard in any way.  Thanks,
> 
>   Jeremiah
> 
> PS - We have a few other custom UI components which we would like to
> extend from CDT managed build classes.  If possible we would probably
> like to make similar "extract method" type refactorings to them.  Let
me
> know if people are open to this.


Back to the top