Need help from a CDT-UI & CDT_TESTING committer (FW: [cdt-patch] initial

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Need help from a CDT-UI & CDT_TESTING committer (FW: [cdt-patch] initial patches for 90334 - custom wizard page support)

From: "Treggiari, Leo" <leo.treggiari@xxxxxxxxx>
Date: Thu, 19 May 2005 09:52:31 -0400
Delivered-to: cdt-patch@xxxxxxxxxxx
List-archive: <http://eclipse.org/pipermail/cdt-patch>
List-help: <mailto:cdt-patch-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/cdt-patch>, <mailto:cdt-patch-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/listinfo/cdt-patch>, <mailto:cdt-patch-request@eclipse.org?subject=unsubscribe>
Thread-index: AcVaWpuu5DziJ1aBTIeDNJI6V9SpJACHuJ6Q
Thread-topic: Need help from a CDT-UI & CDT_TESTING committer (FW: [cdt-patch] initial patches for 90334 - custom wizard page support)

Hi,

I am ready to commit Chris’ MBS changes that add custom new project wizard pages, but there are small patches for CDT-UI (org.eclipse.cdt.ui.patch.txt) and CDT-TESTING (org.eclipse.cdt.testing.patch.txt) that need to be committed first. Any volunteers?

Thanks,

Leo

From: cdt-patch-bounces@xxxxxxxxxxx [mailto:cdt-patch-bounces@xxxxxxxxxxx] On Behalf Of Recoskie, Chris
Sent: Monday, May 16, 2005 5:03 PM
To: CDT patches and commits are posted to this list.
Subject: [cdt-patch] initial patches for 90334 - custom wizard page support

Attached are initial patches for https://bugs.eclipse.org/bugs/show_bug.cgi?id=90334. There are updates to org.eclipse.cdt.managedbuilder.ui in patch form as well as new files in an attached .zip file. There is a new org.eclipse.cdt.managedbuilder.ui.tests plugin that provides some JUnit tests.

Work to support toolchain versioning is still pending and is dependent upon the toolchain versioning support being finished in MBS. I am submitting what I have now so that we can avoid a large integration at the last minute.

Note that there were some small changes to org.eclipse.cdt.testing to automate the tests, as well as a small change to org.eclipse.cdt.ui to populate a wizard page with a page ID.

The implementation has deviated slightly from the proposed design but is largely the same in spirit. I’ll update the design doc once I’m able but I’m waiting on some tools purchases so it may be a bit of a wait.

___________________________________________

Chris Recoskie

Software Designer

IDE Frameworks Group

Texas Instruments, Toronto

Attachment: org.eclipse.cdt.managedbuilder.ui.zip
Description: org.eclipse.cdt.managedbuilder.ui.zip

cvs diff -u (in directory C:\cdt_source_HEAD\org.eclipse.cdt-releng\org.eclipse.cdt.testing\)
cvs diff: Empty password used - try 'cvs login' with a real password

cvs diff: Diffing .
Index: test.xml
===================================================================
RCS file: /home/tools/org.eclipse.cdt-releng/org.eclipse.cdt.testing/test.xml,v
retrieving revision 1.6
diff -u -r1.6 test.xml
--- test.xml	9 Feb 2005 21:43:26 -0000	1.6
+++ test.xml	13 May 2005 16:27:17 -0000
@@ -5,6 +5,7 @@
 	<property name="cdt-ui-loc" value="${eclipse-home}/cdt_ui_folder"/>
 	<property name="cdt-debug-ui-loc" value="${eclipse-home}/cdt_debug_ui_folder"/>
 	<property name="cdt-mbs-loc" value="${eclipse-home}/cdt_mbs_folder"/>
+	<property name="cdt-mbs-ui-loc" value="${eclipse-home}/cdt_mbs_ui_folder"/>
 
 	<target name="init">
 		<tstamp/>
@@ -52,11 +53,20 @@
 		</ant>
 	</target>
 
+	<target name="cdt-mbs-ui" depends="init">
+		<ant target="ui-test" antfile="${library-file}" dir="${eclipse-home}">
+			<property name="data-dir" value="${cdt-mbs-ui-loc}"/>
+			<property name="plugin-name" value="org.eclipse.cdt.managedbuilder.ui.tests"/>
+			<property name="classname" value="org.eclipse.cdt.managedbuilder.ui.tests.AllManagedBuildUITests"/>
+		</ant>
+	</target>
+
 	<target name="suite">
 		<antcall target="cdt-core"/>
 		<antcall target="cdt-ui"/>
 		<antcall target="cdt-debug-ui"/>
 		<antcall target="cdt-mbs"/>
+		<antcall target="cdt-mbs-ui"/>		
 	</target>
 
 </project>

***** CVS exited normally with code 1 *****

cvs diff -u (in directory C:\cdt_source_HEAD\org.eclipse.cdt-build\org.eclipse.cdt.managedbuilder.ui\)
cvs diff: Empty password used - try 'cvs login' with a real password

? schema
? src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSCustomPage.java
? src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSCustomPageData.java
? src/org/eclipse/cdt/managedbuilder/ui/wizards/MBSCustomPageManager.java
cvs diff: Diffing .
Index: build.properties
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/build.properties,v
retrieving revision 1.3
diff -u -r1.3 build.properties
--- build.properties	25 Nov 2003 18:24:26 -0000	1.3
+++ build.properties	11 May 2005 17:43:41 -0000
@@ -4,3 +4,4 @@
                icons/,\
                mgdbuildui.jar
 source.mgdbuildui.jar = src/
+src.includes = schema/
Index: plugin.xml
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/plugin.xml,v
retrieving revision 1.53
diff -u -r1.53 plugin.xml
--- plugin.xml	9 May 2005 03:37:42 -0000	1.53
+++ plugin.xml	11 May 2005 17:10:46 -0000
@@ -22,6 +22,7 @@
       <import plugin="org.eclipse.core.runtime"/>
    </requires>
 
+   <extension-point id="newWizardPages" name="Custom MBS New Wizard Pages" schema="schema/newWizardPages.exsd"/>
 
    <extension
          point="org.eclipse.ui.newWizards">
cvs diff: Diffing icons
cvs diff: Diffing icons/dlcl16
cvs diff: Diffing icons/elcl16
cvs diff: Diffing src
cvs diff: Diffing src/org
cvs diff: Diffing src/org/eclipse
cvs diff: Diffing src/org/eclipse/cdt
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder/internal
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder/internal/ui
Index: src/org/eclipse/cdt/managedbuilder/internal/ui/PluginResources.properties
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/internal/ui/PluginResources.properties,v
retrieving revision 1.30
diff -u -r1.30 PluginResources.properties
--- src/org/eclipse/cdt/managedbuilder/internal/ui/PluginResources.properties	2 May 2005 19:44:51 -0000	1.30
+++ src/org/eclipse/cdt/managedbuilder/internal/ui/PluginResources.properties	16 May 2005 18:57:15 -0000
@@ -65,6 +65,16 @@
 BuildPropertyPage.unsupported.config=The configuration support is not installed on the system
 BuildPropertyPage.config.notselected=No configurations selected
 
+# ----------- Managed Build Custom Wizard Page Manager Error Strings -----------
+MBSCustomPageManager.error0=Unknown element type 
+MBSCustomPageManager.error1=\ for extension point 
+MBSCustomPageManager.error2=Unknown child element type 
+MBSCustomPageManager.error3=\ for wizardPage element in extension point 
+MBSCustomPageManager.error4=Missing projectType ID
+MBSCustomPageManager.error5=Missing projectType ID
+MBSCustomPageManager.error6=Missing nature ID
+
+
 # ----------- Managed Build Preference Page -----------
 BuildPreferencePage.label.Settings=Workspace Settings
 BuildPreferencePage.job.rebuild=Rebuilding the Managed Projects
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder/toolchain
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder/toolchain/gnu
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder/toolchain/gnu/cygwin
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder/ui
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder/ui/properties
cvs diff: Diffing src/org/eclipse/cdt/managedbuilder/ui/wizards
Index: src/org/eclipse/cdt/managedbuilder/ui/wizards/CProjectPlatformPage.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/CProjectPlatformPage.java,v
retrieving revision 1.11
diff -u -r1.11 CProjectPlatformPage.java
--- src/org/eclipse/cdt/managedbuilder/ui/wizards/CProjectPlatformPage.java	18 Apr 2005 04:15:07 -0000	1.11
+++ src/org/eclipse/cdt/managedbuilder/ui/wizards/CProjectPlatformPage.java	13 May 2005 13:30:28 -0000
@@ -14,6 +14,8 @@
 import java.util.Arrays;
 import java.util.List;
 import java.util.ListIterator;
+import java.util.Set;
+import java.util.LinkedHashSet;
 
 import org.eclipse.cdt.managedbuilder.core.IProjectType;
 import org.eclipse.cdt.managedbuilder.core.IConfiguration;
@@ -63,6 +65,12 @@
 	private static final String TARGET_LABEL = LABEL + ".platform"; //$NON-NLS-1$
 	private static final String TARGET_TIP = TIP + ".platform"; //$NON-NLS-1$
 
+	// support for exporting data to custom wizard pages
+	public static final String PAGE_ID = "org.eclipse.cdt.managedbuilder.ui.wizard.platformPage"; //$NON-NLS-1$
+	public static final String PROJECT_TYPE = "projectType"; //$NON-NLS-1$
+	public static final String TOOLCHAIN = "toolchain"; //$NON-NLS-1$
+	public static final String NATURE = "nature"; //$NON-NLS-1$
+	
 	protected NewManagedProjectWizard parentWizard;
 	protected Combo platformSelection;
 	private ArrayList selectedConfigurations;
@@ -257,6 +265,25 @@
 		// Get the selections from the table viewer
 		selectedConfigurations.clear();
 		selectedConfigurations.addAll(Arrays.asList(tableViewer.getCheckedElements()));
+		
+		// support for publishing the toolchains for the selected configs so that custom wizard
+		// pages will know which toolchains have been selected
+		
+		// get the toolchains from the selected configs and put them into a set
+		Set toolchainSet = new LinkedHashSet();
+		
+		for(int k = 0; k < selectedConfigurations.size(); k++)
+		{
+			IConfiguration config = (IConfiguration) selectedConfigurations.get(k);
+			
+			IToolChain toolchain = config.getToolChain();
+			
+			toolchainSet.add(toolchain);
+		}
+		
+		// publish the set of selected toolchains with the custom page manager
+		MBSCustomPageManager.addPageProperty(PAGE_ID, TOOLCHAIN, toolchainSet);
+		
 		setPageComplete(validatePage());
 	}
 
@@ -277,6 +304,9 @@
 			if (selectedProjectType != (IProjectType) projectTypes.get(index)) {
 				selectedProjectType = (IProjectType) projectTypes.get(index);
 				parentWizard.updateProjectTypeProperties();
+				
+				// publish which project type has been chosen with the custom wizard page manager
+				MBSCustomPageManager.addPageProperty(PAGE_ID, PROJECT_TYPE, selectedProjectType.getId());
 			}
 		}
 		populateConfigurations();
Index: src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedCCProjectWizard.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedCCProjectWizard.java,v
retrieving revision 1.2
diff -u -r1.2 NewManagedCCProjectWizard.java
--- src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedCCProjectWizard.java	19 May 2004 19:36:11 -0000	1.2
+++ src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedCCProjectWizard.java	11 May 2005 18:28:46 -0000
@@ -12,11 +12,14 @@
  * **********************************************************************/
 
 import org.eclipse.cdt.core.CCorePlugin;
+import org.eclipse.cdt.core.CCProjectNature;
+import org.eclipse.cdt.managedbuilder.core.BuildException;
 import org.eclipse.cdt.managedbuilder.internal.ui.ManagedBuilderUIMessages;
 import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.NullProgressMonitor;
 import org.eclipse.core.runtime.SubProgressMonitor;
+import org.eclipse.jface.wizard.IWizardPage;
 
 public class NewManagedCCProjectWizard extends NewManagedProjectWizard {
 	private static final String WZ_TITLE = "MngCCWizard.title";	//$NON-NLS-1$
@@ -27,15 +30,44 @@
 	
 	public NewManagedCCProjectWizard() {
 		this(ManagedBuilderUIMessages.getResourceString(WZ_TITLE), ManagedBuilderUIMessages.getResourceString(WZ_DESC));
+
 	}
 
 	public NewManagedCCProjectWizard(String title, String desc) {
 		super(title, desc);
+
 	}
 
 	public void addPages() {
 		// Add the default page for all new managed projects 
 		super.addPages();
+
+		// support for custom wizard pages
+		// publish our nature with the page manager
+		MBSCustomPageManager.addPageProperty(CProjectPlatformPage.PAGE_ID, CProjectPlatformPage.NATURE, CCProjectNature.CC_NATURE_ID);
+		
+		// load all pages specified via extensions
+		try
+		{
+			MBSCustomPageManager.loadExtensions();
+		}
+		
+		catch (BuildException e)
+		{
+			e.printStackTrace();
+		}
+		
+		
+		IWizardPage[] customPages = MBSCustomPageManager.getCustomPages();
+		
+		
+		if (customPages != null)
+		{
+			for (int k = 0; k < customPages.length; k++)
+			{
+				addPage(customPages[k]);
+			}
+		}
 	}
 
 	protected void doRun(IProgressMonitor monitor) throws CoreException {
Index: src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedCProjectWizard.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedCProjectWizard.java,v
retrieving revision 1.4
diff -u -r1.4 NewManagedCProjectWizard.java
--- src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedCProjectWizard.java	4 Jun 2004 20:17:54 -0000	1.4
+++ src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedCProjectWizard.java	11 May 2005 18:29:20 -0000
@@ -11,7 +11,15 @@
  * IBM Rational Software - Initial API and implementation
  * **********************************************************************/
 
+import org.eclipse.cdt.core.CProjectNature;
+import org.eclipse.cdt.managedbuilder.core.BuildException;
+import org.eclipse.cdt.managedbuilder.internal.core.ManagedMakeMessages;
 import org.eclipse.cdt.managedbuilder.internal.ui.ManagedBuilderUIMessages;
+import org.eclipse.jface.dialogs.MessageDialog;
+import org.eclipse.jface.wizard.IWizardPage;
+import org.eclipse.swt.widgets.Shell;
+import org.eclipse.ui.IWorkbenchWindow;
+import org.eclipse.ui.PlatformUI;
 
 public class NewManagedCProjectWizard extends NewManagedProjectWizard {
 	// String constants
@@ -34,6 +42,32 @@
 	public void addPages() {
 		// Add the default page for all new managed projects 
 		super.addPages();
+		
+		// support for custom wizard pages
+		// publish our nature with the page manager
+		MBSCustomPageManager.addPageProperty(CProjectPlatformPage.PAGE_ID, CProjectPlatformPage.NATURE, CProjectNature.C_NATURE_ID);
+		
+		// load all pages specified via extensions
+		try
+		{
+			MBSCustomPageManager.loadExtensions();
+		}
+		
+		catch (BuildException e)
+		{
+			e.printStackTrace();
+		}
+		
+		
+		IWizardPage[] customPages = MBSCustomPageManager.getCustomPages();
+		
+		if (customPages != null)
+		{
+			for (int k = 0; k < customPages.length; k++)
+			{
+				addPage(customPages[k]);
+			}
+		}
 	}
 
 }
Index: src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedProjectOptionPage.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedProjectOptionPage.java,v
retrieving revision 1.8
diff -u -r1.8 NewManagedProjectOptionPage.java
--- src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedProjectOptionPage.java	28 Jan 2005 03:31:54 -0000	1.8
+++ src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedProjectOptionPage.java	13 May 2005 13:41:01 -0000
@@ -26,10 +26,12 @@
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.runtime.Preferences;
 import org.eclipse.ui.help.WorkbenchHelp;
+import org.eclipse.jface.wizard.IWizardPage;
 
 public class NewManagedProjectOptionPage extends NewCProjectWizardOptionPage {
 	
-
+	public static final String PAGE_ID = "org.eclipse.cdt.managedbuilder.ui.wizard.projectOptionsPage"; //$NON-NLS-1$
+	
 	public class ManagedWizardOptionBlock extends ManagedProjectOptionBlock {
 		
 		NewManagedProjectOptionPage parent;
@@ -127,4 +129,9 @@
 		optionBlock.setupHelpContextIds();
 	}
 	
+	public IWizardPage getNextPage()
+	{
+		return MBSCustomPageManager.getNextPage(PAGE_ID); // get first custom page, if any
+	}
+	
 }
Index: src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedProjectWizard.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedProjectWizard.java,v
retrieving revision 1.19
diff -u -r1.19 NewManagedProjectWizard.java
--- src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedProjectWizard.java	28 Apr 2005 16:55:15 -0000	1.19
+++ src/org/eclipse/cdt/managedbuilder/ui/wizards/NewManagedProjectWizard.java	11 May 2005 15:56:34 -0000
@@ -62,6 +62,7 @@
 
 	public NewManagedProjectWizard() {
 		this(ManagedBuilderUIMessages.getResourceString(WZ_TITLE), ManagedBuilderUIMessages.getResourceString(WZ_DESC));
+		
 	}
 
 	public NewManagedProjectWizard(String title, String description) {
@@ -83,6 +84,15 @@
 		optionPage.setTitle(ManagedBuilderUIMessages.getResourceString(OPTIONS_TITLE));
 		optionPage.setDescription(ManagedBuilderUIMessages.getResourceString(OPTIONS_DESC));
 		addPage(optionPage);
+		
+		// add custom pages
+		MBSCustomPageManager.init();
+		
+		// add stock pages
+		MBSCustomPageManager.addStockPage(fMainPage, NewCProjectWizardPage.PAGE_ID);
+		MBSCustomPageManager.addStockPage(projectConfigurationPage, CProjectPlatformPage.PAGE_ID);
+		MBSCustomPageManager.addStockPage(optionPage, NewManagedProjectOptionPage.PAGE_ID);
+		
 	}
 	
 	public void createPageControls(Composite pageContainer) {
@@ -217,6 +227,17 @@
 			// At this point, I can live with a failure
 			ManagedBuilderUIPlugin.log(initResult);
 		}
+		
+		// execute any operations specified by custom pages
+		Runnable operations[] = MBSCustomPageManager.getOperations();
+		
+		if(operations != null)
+		{
+			for(int k = 0; k < operations.length; k++)
+			{
+				operations[k].run();
+			}
+		}
 	}
 
 	/* (non-Javadoc)

***** CVS exited normally with code 1 *****

Attachment: org.eclipse.cdt.managedbuilder.ui.tests.zip
Description: org.eclipse.cdt.managedbuilder.ui.tests.zip

cvs diff -u (in directory C:\cdt_source_HEAD\org.eclipse.cdt-core\org.eclipse.cdt.ui\)
cvs diff: Empty password used - try 'cvs login' with a real password

cvs diff: Diffing .
cvs diff: Diffing browser
cvs diff: Diffing browser/org
cvs diff: Diffing browser/org/eclipse
cvs diff: Diffing browser/org/eclipse/cdt
cvs diff: Diffing browser/org/eclipse/cdt/internal
cvs diff: Diffing browser/org/eclipse/cdt/internal/ui
cvs diff: Diffing browser/org/eclipse/cdt/internal/ui/browser
cvs diff: Diffing browser/org/eclipse/cdt/internal/ui/browser/cbrowsing
cvs diff: Diffing browser/org/eclipse/cdt/internal/ui/browser/opentype
cvs diff: Diffing browser/org/eclipse/cdt/internal/ui/browser/typehierarchy
cvs diff: Diffing browser/org/eclipse/cdt/ui
cvs diff: Diffing browser/org/eclipse/cdt/ui/browser
cvs diff: Diffing browser/org/eclipse/cdt/ui/browser/typeinfo
cvs diff: Diffing icons
cvs diff: Diffing icons/dlcl16
cvs diff: Diffing icons/dtool16
cvs diff: Diffing icons/elcl16
cvs diff: Diffing icons/etool16
cvs diff: Diffing icons/obj16
cvs diff: Diffing icons/ovr16
cvs diff: Diffing icons/view16
cvs diff: Diffing icons/wizban
cvs diff: Diffing refactor
cvs diff: Diffing refactor/org
cvs diff: Diffing refactor/org/eclipse
cvs diff: Diffing refactor/org/eclipse/cdt
cvs diff: Diffing refactor/org/eclipse/cdt/internal
cvs diff: Diffing refactor/org/eclipse/cdt/internal/corext
cvs diff: Diffing refactor/org/eclipse/cdt/internal/corext/refactoring
cvs diff: Diffing refactor/org/eclipse/cdt/internal/corext/refactoring/base
cvs diff: Diffing refactor/org/eclipse/cdt/internal/corext/refactoring/changes
cvs diff: Diffing refactor/org/eclipse/cdt/internal/corext/refactoring/rename
cvs diff: Diffing refactor/org/eclipse/cdt/internal/ui
cvs diff: Diffing refactor/org/eclipse/cdt/internal/ui/refactoring
cvs diff: Diffing refactor/org/eclipse/cdt/internal/ui/refactoring/actions
cvs diff: Diffing schema
cvs diff: Diffing src
cvs diff: Diffing src/org
cvs diff: Diffing src/org/eclipse
cvs diff: Diffing src/org/eclipse/cdt
cvs diff: Diffing src/org/eclipse/cdt/internal
cvs diff: Diffing src/org/eclipse/cdt/internal/corext
cvs diff: Diffing src/org/eclipse/cdt/internal/corext/template
cvs diff: Diffing src/org/eclipse/cdt/internal/corext/template/c
cvs diff: Diffing src/org/eclipse/cdt/internal/corext/textmanipulation
cvs diff: Diffing src/org/eclipse/cdt/internal/corext/util
cvs diff: Diffing src/org/eclipse/cdt/internal/ui
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/actions
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/buildconsole
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/codemanipulation
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/compare
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/cview
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/dialogs
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/dialogs/cpaths
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/dnd
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/editor
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/editor/asm
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/filters
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/preferences
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/search
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/search/actions
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/text
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/text/c
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/text/c/hover
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/text/contentassist
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/text/folding
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/text/template
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/text/util
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/util
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/viewsupport
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/wizards
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/wizards/classwizard
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/wizards/dialogfields
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/wizards/filewizard
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/wizards/folderwizard
cvs diff: Diffing src/org/eclipse/cdt/internal/ui/workingsets
cvs diff: Diffing src/org/eclipse/cdt/ui
cvs diff: Diffing src/org/eclipse/cdt/ui/actions
cvs diff: Diffing src/org/eclipse/cdt/ui/dialogs
cvs diff: Diffing src/org/eclipse/cdt/ui/index
cvs diff: Diffing src/org/eclipse/cdt/ui/text
cvs diff: Diffing src/org/eclipse/cdt/ui/text/c
cvs diff: Diffing src/org/eclipse/cdt/ui/text/c/hover
cvs diff: Diffing src/org/eclipse/cdt/ui/text/contentassist
cvs diff: Diffing src/org/eclipse/cdt/ui/text/folding
cvs diff: Diffing src/org/eclipse/cdt/ui/wizards
Index: src/org/eclipse/cdt/ui/wizards/NewCProjectWizardPage.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/wizards/NewCProjectWizardPage.java,v
retrieving revision 1.2
diff -u -r1.2 NewCProjectWizardPage.java
--- src/org/eclipse/cdt/ui/wizards/NewCProjectWizardPage.java	10 Jun 2004 17:10:04 -0000	1.2
+++ src/org/eclipse/cdt/ui/wizards/NewCProjectWizardPage.java	13 May 2005 18:28:48 -0000
@@ -24,6 +24,29 @@
  */
 public class NewCProjectWizardPage extends WizardNewProjectCreationPage {
 
+	/**
+	 *  Unique string ID for this page.  Used by Managed Build's custom page manager to refer to this page.
+	 */
+	public static final String PAGE_ID = "org.eclipse.cdt.ui.wizard.basicPage"; //$NON-NLS-1$
+	
+	/* TODO: Implement proper data publishing from this wizard page.
+	 * 
+	 * The following items would in theory be used to publish the project name and location with
+	 * the managed build system's custom wizard page manager.  However, this would create a dependency
+	 * on MBS by the core, which is not very attractive.  It seems like it might be worthwhile in the future
+	 * to move the data publishing capabilities of the page manager out into another, more generic class
+	 * in the core.
+	 * 
+	 * For now, interested parties can obtain the IWizard page of this page from the page manager, cast it
+	 * to a NewCProjectWizardPage, and obtain the data via its public methods.  Messy, but it avoids
+	 * the unwanted dependency. 
+	 * 
+	 * 
+	public static final String PROJECT_NAME = "projectName"; //$NON-NLS-1$
+	public static final String PROJECT_LOCATION = "projectLocation"; //$NON-NLS-1$
+	*/
+	
+	
 	public NewCProjectWizardPage(String pageName) {
 		super(pageName);
 	}
@@ -51,6 +74,8 @@
 				setErrorMessage(validLocation.getMessage());
 				return false;
 			}
+			
+			
 			return true;
 		}
 		return false;
cvs diff: Diffing src/org/eclipse/cdt/ui/wizards/conversion
cvs diff: Diffing templates
cvs diff: Diffing utils.ui
cvs diff: Diffing utils.ui/org
cvs diff: Diffing utils.ui/org/eclipse
cvs diff: Diffing utils.ui/org/eclipse/cdt
cvs diff: Diffing utils.ui/org/eclipse/cdt/utils
cvs diff: Diffing utils.ui/org/eclipse/cdt/utils/ui
cvs diff: Diffing utils.ui/org/eclipse/cdt/utils/ui/controls

***** CVS exited normally with code 1 *****

_______________________________________________
cdt-patch mailing list
cdt-patch@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cdt-patch

Prev by Date: [cdt-patch] FIXED 95635- [GCCBuiltinSymbolProvider] needs to support additional Other built-in GCC symbols
Next by Date: [cdt-patch] FIXED 86868, 95635, 95786
Previous by thread: [cdt-patch] FIXED 95635- [GCCBuiltinSymbolProvider] needs to support additional Other built-in GCC symbols
Next by thread: [cdt-patch] FIXED 86868, 95635, 95786
Index(es):
- Date
- Thread

Breadcrumbs