Applied: Re: [cdt-patch] FIXED 86829, 93589, 94360

[Andrew Niefer <aniefer@xxxxxxxxxx>]

Applied.

 thanks,
Andrew

cdt-patch-bounces@xxxxxxxxxxx wrote on 05/10/2005 03:28:18 PM:

>
> Updated the patch to include your suggestions and fix the following:
>
> FIXED 86829- Open Declaration on implicit constructor reference
> FIXED 93589- Open Declaration on parameter yields NPE
> FIXED 94360- [Open Definition/Declaration] SelectionTests should
> disable indexer to ensure correctness of DOM AST
>
> Devin Steffler
> IBM's Eclipse CDT
> Ottawa (Palladium), Ontario, Canada
>
>
>
>

>
> Andrew Niefer/Ottawa/IBM@IBMCA
> Sent by: cdt-patch-bounces@xxxxxxxxxxx
> 05/09/2005 04:36 PM
>
> Please respond to
> "CDT patches and commits are posted to this list."
>
> To
>
> cdt-patch@xxxxxxxxxxx
>
> cc
>
> Subject
>
> Rejected: Re: [cdt-patch] FIXED 86829- Open Declaration on implicit
> constructor reference
>
>
>
>
> It would be better if the DOMSearchUtil didn't depend directly on the
> binding implementation classes.
> So instead of binding instanceof CPPImplicitMethod, I would suggest
> instanceof ICPPConstructor.  I'm not sure that we want to open the class
> for methods that aren't constructors, at least the constructors have the
> same name as the class.
>
> And, an easier way to get the class binding would be:  ((ICPPClassScope)
> binding.getScope()).getClassType()
>
> Also, I notice that SelectionTests.testBasicDefinition() is failing
(though
> it was failing without the patch as well).
>
> -Andrew
> cdt-patch-bounces@xxxxxxxxxxx wrote on 05/09/2005 03:31:55 PM:
>
> >
> > FIXED 86829- Open Declaration on implicit constructor reference
> >
> > Devin Steffler
> > IBM's Eclipse CDT
> > Ottawa (Palladium), Ontario, Canada
> > [attachment "cdt_core_tests_patch.txt" deleted by Andrew
> > Niefer/Ottawa/IBM] [attachment "cdt_core_patch.txt" deleted by
> > Andrew Niefer/Ottawa/IBM] [attachment "cdt_ui_tests_patch.txt"
> > deleted by Andrew Niefer/Ottawa/IBM]
> > _______________________________________________
> > cdt-patch mailing list
> > cdt-patch@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/cdt-patch
>
> _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-patch
> [attachment "cdt_ui_tests_patch.txt" deleted by Andrew
> Niefer/Ottawa/IBM] [attachment "cdt_core_tests_patch.txt" deleted by
> Andrew Niefer/Ottawa/IBM] [attachment "cdt_core_patch.txt" deleted
> by Andrew Niefer/Ottawa/IBM]
_______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-patch