Rejected: Re: [cdt-patch] FIXED 86829- Open Declaration on implicit cons

[Andrew Niefer <aniefer@xxxxxxxxxx>]

It would be better if the DOMSearchUtil didn't depend directly on the
binding implementation classes.
So instead of binding instanceof CPPImplicitMethod, I would suggest
instanceof ICPPConstructor.  I'm not sure that we want to open the class
for methods that aren't constructors, at least the constructors have the
same name as the class.

And, an easier way to get the class binding would be:  ((ICPPClassScope)
binding.getScope()).getClassType()

Also, I notice that SelectionTests.testBasicDefinition() is failing (though
it was failing without the patch as well).

-Andrew
cdt-patch-bounces@xxxxxxxxxxx wrote on 05/09/2005 03:31:55 PM:

>
> FIXED 86829- Open Declaration on implicit constructor reference
>
> Devin Steffler
> IBM's Eclipse CDT
> Ottawa (Palladium), Ontario, Canada
> [attachment "cdt_core_tests_patch.txt" deleted by Andrew
> Niefer/Ottawa/IBM] [attachment "cdt_core_patch.txt" deleted by
> Andrew Niefer/Ottawa/IBM] [attachment "cdt_ui_tests_patch.txt"
> deleted by Andrew Niefer/Ottawa/IBM]
> _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/cdt-patch