RE: [cdt-patch] Patches for Bugzilla 88150-settingmultiplebinaryparsers

["Treggiari, Leo" <leo.treggiari@xxxxxxxxx>]

Applied to CDT 2.1.1.

 

Thanks,

Leo

 

---

From: cdt-patch-bounces@xxxxxxxxxxx [mailto:cdt-patch-bounces@xxxxxxxxxxx] On Behalf Of Ploett Norbert
Sent: Tuesday, April 19, 2005 8:42 AM
To: CDT patches and commits are posted to this list.
Subject: AW: [cdt-patch] Patches for Bugzilla 88150-settingmultiplebinaryparsers in project type

 

Hello Leo and all,

 

here is a re-play of the patches to CDT 2.1.1 which eliminate the "entire file problem", and at the same time pick up your other suggestions (keeping methods, semicolon-separated lists).

 

 

Norbert

 

---

Von: cdt-patch-bounces@xxxxxxxxxxx [mailto:cdt-patch-bounces@xxxxxxxxxxx] Im Auftrag von Treggiari, Leo
Gesendet: Montag, 18. April 2005 18:47
An: CDT patches and commits are posted to this list.
Betreff: RE: [cdt-patch] Patches for Bugzilla 88150 -settingmultiplebinaryparsers in project type

Hi Norbert,

 

There is no documented guideline that I am aware of.  I have been using comma-separated for simple strings such as file-extensions, os-names, and semi-colons for ids and paths.

 

I just looked at your 2.1.1 patches and there is something wrong with them.  They appear to contain entire files.  That may have been because of line-ending differences between the two file versions being compared.  You’ll have to resubmit the 2.1.1 patches.

 

Regards,

Leo

 

---

From: cdt-patch-bounces@xxxxxxxxxxx [mailto:cdt-patch-bounces@xxxxxxxxxxx] On Behalf Of Ploett Norbert
Sent: Monday, April 18, 2005 7:38 AM
To: CDT patches and commits are posted to this list.
Subject: AW: [cdt-patch] Patches for Bugzilla 88150 - settingmultiplebinaryparsers in project type

 

Leo,

 

I don't care about commas or semicolons and accept your changes.

 

I was just surprised because I had looked at the source code in TargetPlatform, immediately before my changes. The architectures and OS lists are comma-separated. I was also aware that there are other lists which are semicolon-separated.

Is there a documented guideline on this?

 

Regards,

 

 

Norbert

 

---

Von: cdt-patch-bounces@xxxxxxxxxxx [mailto:cdt-patch-bounces@xxxxxxxxxxx] Im Auftrag von Treggiari, Leo
Gesendet: Montag, 18. April 2005 06:21
An: CDT patches and commits are posted to this list.
Betreff: RE: [cdt-patch] Patches for Bugzilla 88150 - setting multiplebinaryparsers in project type

Applied to Head with the following changes:

1. Change the list from comma-separated to semi-colon-separated.  All other ID lists are semi-colon separated.
2. Kept the {get|set}BinaryParserId methods and marked them as deprecated

 

I will apply the same changes to 2.1.1 in the next few days.

 

Thanks,

Leo

 

---

From: cdt-patch-bounces@xxxxxxxxxxx [mailto:cdt-patch-bounces@xxxxxxxxxxx] On Behalf Of Ploett Norbert
Sent: Tuesday, April 12, 2005 8:01 AM
To: cdt-patch@xxxxxxxxxxx
Subject: [cdt-patch] Patches for Bugzilla 88150 - setting multiple binaryparsers in project type

 

Hello all,

 

im am suggesting a set of patches to the managed build system for versions 3.0.0 (M6 candidate from yesterday) and 2.1.1.

 

The patch aims to allow setting multiple binary parsers in a project type as a comma-separated list, analogous to the list of operating systems for target platform.

 

Find more details in the bugzilla entry https://bugs.eclipse.org/bugs/show_bug.cgi?id=88150.

 

Regards,

 

Norbert Ploett