Re: [cdt-patch] patch for AST View - speed + display problems

[John Camelon <jcamelon@xxxxxxxxxx>]

Hi Devin, 

I'll look into this once we declare
M5.
Thanks

JohnC
www.eclipse.org/cdt

cdt-patch-admin@xxxxxxxxxxx wrote on 03/14/2005 10:55:00
AM:

> 
> This patch includes: 
> - several enhancements made to the DOM AST View to improve performance
> - "Display Problems" button that will display all found
IASTProblems
> in the AST via the Search View 
> 
> Note: 
> - with this patch the view now generates/searches the AST View's 
> model with a vastly improved algorithm (so that only the necessary
> branches of the AST are taken when searching for a node)... although
> this is much faster than the previous algorithm, any small bugs will
> cause the AST View to less resemble the actual AST itself (ex: if
a 
> parent is not displayed in the AST View because it has 0 offset, 
> then all children of that parent are grouped under that parent 
> instead of having a proper tree) 
> - another enhancement was to use arrays instead of ArrayLists and
to
> only sort nodes when they are viewed graphically in the tree 
> (instead of sorting nodes everytime they are merged into the tree)
> ... this helps improve the speed when the View is generated, but 
> slows things down when expanding a tree with a large set of children
> - I raised the following bugs that were found with this patch via
> #including <windows.h>: 
> 87894  [Offset] example from windows.h generates weird AST in
DOM View 
> 86993  [Selection] CPPASTLinkageSpecification with bad offset
due to
> macro expansion causes selection to fail in CPP 
> 
> Devin Steffler
> IBM's Eclipse CDT
> Ottawa (Palladium), Ontario, Canada [attachment "cdt_core_patch.txt"
> deleted by John Camelon/Ottawa/IBM] [attachment "cdt_ui_tests_patch.
> txt" deleted by John Camelon/Ottawa/IBM]