RE: [cdt-patch] Proposed bug fix for bugzilla 83214

["Treggiari, Leo" <leo.treggiari@xxxxxxxxx>]

Hi Tracy,

I am rejecting this patch.  It would be impossible to change the default
without possibly effecting existing tool integrations that are relying
upon the default.  If an arguments value of "" is correct for your
tool-chain, you can specify that in your tool-chain definitions.

Regards,
Leo


-----Original Message-----
From: cdt-patch-admin@xxxxxxxxxxx [mailto:cdt-patch-admin@xxxxxxxxxxx]
On Behalf Of Tracy Miranda
Sent: Thursday, February 03, 2005 1:17 PM
To: cdt-patch@xxxxxxxxxxx
Subject: [cdt-patch] Proposed bug fix for bugzilla 83214

Hi,

Here's a proposed fix for this bugzilla 83214. It simply sets the
default build arguments to "" instead of "-k". So if the user doesn't
specify any build arguments in their plugin xml they don't automatically
get the -k flag.

If you're happy with this as fix, we'd like it to be committed to the
2.1.1 branch as well as our managed build toolchain is currently
affected. 

The patch is for the Builder.java file in
org.eclipse.cdt.managedbuilder.internal.core. Let me know if I have to
provide anything else. 

Thanks,
Tracy Miranda
Altera Europe