Rejected: Re: [cdt-patch] [FIXED] 72611 patch

[John Camelon <jcamelon@xxxxxxxxxx>]

For the time being, this patch needs
to be rejected.  
It is proving difficult to write JUnit
tests that cancel a parse, since different computers run at completely
different rates and Windows's general lack of respect for thread priorities.
Let's put this on the back burner until
we think about it some more. 

JohnC
www.eclipse.org/cdt

cdt-patch-admin@xxxxxxxxxxx wrote on 10/01/2004 02:46:48
PM:

> 
> I cleaned up the code and added a test for 
> 'bufferPos[index] = bufferLimit[index];' 
> 
> John, I noticed that this code will often return a null token to 
> nextToken() so 
> I added the following: 
> 
>                 if (finished)
>                 { 
> +                    
   if (isCancelled) 
> +                    
           throw new ParseError( ParseError.
> ParseErrorKind.TIMEOUT_OR_CANCELLED); 
>                    
    
>                    
    if( offsetBoundary == -1 ) 
>                    
            throw EOF;      
                  
>                    
    throwOLRE(); 
>                 } 
> 
> [FIXED] 72611 [Parser] Timeout strategy does not affect scanner infinite
loops
> 
> 
> 
> Devin Steffler
> IBM's Eclipse CDT
> Ottawa (Palladium), Ontario, Canada[attachment "cdt_core.txt"
> deleted by John Camelon/Ottawa/IBM] [attachment "cdt_core_tests.txt"
> deleted by John Camelon/Ottawa/IBM]