Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-patch] Scanner config discovery - fix for PR 70267

This patch contains a fix for
PR 70267: TVT3.0:  In japanese locale, automated discovery of include 
paths doesn't seem to work
and another small fix.

Applicable to both HEAD and the branch.

Thanks,
Vmir
Index: src/org/eclipse/cdt/make/internal/core/scannerconfig/DefaultExternalScannerInfoProvider.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/scannerconfig/DefaultExternalScannerInfoProvider.java,v
retrieving revision 1.10.2.1
diff -u -r1.10.2.1 DefaultExternalScannerInfoProvider.java
--- src/org/eclipse/cdt/make/internal/core/scannerconfig/DefaultExternalScannerInfoProvider.java	13 Jul 2004 20:48:53 -0000	1.10.2.1
+++ src/org/eclipse/cdt/make/internal/core/scannerconfig/DefaultExternalScannerInfoProvider.java	28 Jul 2004 19:09:46 -0000
@@ -52,6 +52,7 @@
 	
 	private static final String EXTERNAL_SI_PROVIDER_ERROR = "ExternalScannerInfoProvider.Provider_Error"; //$NON-NLS-1$
 	private static final String EXTERNAL_SI_PROVIDER_CONSOLE_ID = MakeCorePlugin.getUniqueIdentifier() + ".ExternalScannerInfoProviderConsole";	//$NON-NLS-1$
+	private static final String LANG_ENV_VAR = "LANG";
 	
 	private IPath fWorkingDirectory;
 	private IPath fCompileCommand;
@@ -224,6 +225,10 @@
 		Properties props = launcher.getEnvironment();
 		props.put("CWD", fWorkingDirectory.toOSString()); //$NON-NLS-1$
 		props.put("PWD", fWorkingDirectory.toOSString()); //$NON-NLS-1$
+		// Reset LANG variable only if it is already set
+		if (props.containsKey(LANG_ENV_VAR)) {
+			props.put(LANG_ENV_VAR, "en_US.UTF-8"); //$NON-NLS-1$
+		}
 		String[] env = null;
 		ArrayList envList = new ArrayList();
 		Enumeration names = props.propertyNames();
Index: src/org/eclipse/cdt/make/internal/core/scannerconfig/ScannerInfoCollector.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.make.core/src/org/eclipse/cdt/make/internal/core/scannerconfig/ScannerInfoCollector.java,v
retrieving revision 1.13
diff -u -r1.13 ScannerInfoCollector.java
--- src/org/eclipse/cdt/make/internal/core/scannerconfig/ScannerInfoCollector.java	22 Jun 2004 13:19:49 -0000	1.13
+++ src/org/eclipse/cdt/make/internal/core/scannerconfig/ScannerInfoCollector.java	28 Jul 2004 19:09:46 -0000
@@ -36,6 +36,7 @@
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.ISafeRunnable;
+import org.eclipse.core.runtime.NullProgressMonitor;
 import org.eclipse.core.runtime.Path;
 import org.eclipse.core.runtime.Platform;
 import org.eclipse.core.runtime.SubProgressMonitor;
@@ -372,6 +373,9 @@
 	 * @param monitor
 	 */
 	public synchronized void updateScannerConfiguration(IProject project, IProgressMonitor monitor) throws CoreException {
+		if (monitor == null) {
+			monitor = new NullProgressMonitor();
+		}
 		currentProject = project;
 		String projectName = project.getName();
 		// check TSO for the project

Back to the top