Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-patch] 2nd fix for 70217


This one keeps the FormData for the controls, but checks for the longest label to align by.
Tested on Windows and Linux, in various languages including Japanese.
Thanks,
Tanya

Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.managedbuilder.ui/ChangeLog,v
retrieving revision 1.19
diff -u -r1.19 ChangeLog
--- ChangeLog	15 Jun 2004 19:37:27 -0000	1.19
+++ ChangeLog	21 Jul 2004 18:26:43 -0000
@@ -1,3 +1,7 @@
+2004-07-21 Tanya Wolff
+	Fix for 70217: C++ Build Properties view: Platform overlaps field
+	* src/org/eclipse/cdt/managedbuilder/ui/properties/BuildPropertyPage.java
+
 2004-06-15 Tanya Wolff
 	Removed intermediate composites to allow groupings to be readable by screenreader in the Manage Configuration dialog.
 	
Index: src/org/eclipse/cdt/managedbuilder/ui/properties/BuildPropertyPage.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/BuildPropertyPage.java,v
retrieving revision 1.20
diff -u -r1.20 BuildPropertyPage.java
--- src/org/eclipse/cdt/managedbuilder/ui/properties/BuildPropertyPage.java	18 Jun 2004 18:35:06 -0000	1.20
+++ src/org/eclipse/cdt/managedbuilder/ui/properties/BuildPropertyPage.java	21 Jul 2004 18:26:44 -0000
@@ -240,9 +240,10 @@
 		fd.top = new FormAttachment(configSelector, 0, SWT.CENTER);
 		fd.right = new FormAttachment(100,0);
 		manageConfigs.setLayoutData(fd);
-		// Anchor config combo left 5 pixels from label, top 5% below the centre, and right to the button
+		// Anchor config combo left 5 pixels from longest label, top 5% below the centre, and right to the button
+		Label longestLabel = (platformLabel.getText().length()>configLabel.getText().length()?platformLabel:configLabel);
 		fd = new FormData();
-		fd.left = new FormAttachment(configLabel, 5); 
+		fd.left = new FormAttachment(longestLabel, 5); 
 		fd.top = new FormAttachment(55,0);
 		fd.right = new FormAttachment(manageConfigs, -5 , SWT.LEFT);
 		configSelector.setLayoutData(fd);		

Back to the top