Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-patch] Re: Patch: define _XOPEN_SOURCE

Tom> I needed this patch on Linux to get a prototype for ptsname.
Tom> Without this you might be able to observe a bug on a 64-bit platform
Tom> as ptsname will be implicitly declared to return int.  (I didn't
Tom> actually observe such a bug here, but I recently fixed a similar one
Tom> in the launcher...)

Argh, sorry, this is incorrect.  Defining _XOPEN_SOURCE will turn off
some other extensions that are in use.  Instead we must define
_GNU_SOURCE.  I'm not sure how I missed this the first time around
:-(.  Anyway, this version causes no warnings.

Tom

Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core.linux/ChangeLog,v
retrieving revision 1.5
diff -u -r1.5 ChangeLog
--- ChangeLog	25 Mar 2004 19:41:11 -0000	1.5
+++ ChangeLog	12 Jul 2004 22:23:42 -0000
@@ -1,3 +1,7 @@
+2004-07-12  Tom Tromey  <tromey@xxxxxxxxxx>
+
+	* library/Makefile (CFLAGS): Define _GNU_SOURCE.
+
 2004-03-25 David Inglis
 	
 	Added platform attribute to processlist extension
Index: library/Makefile
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core.linux/library/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- library/Makefile	31 Jan 2003 20:00:25 -0000	1.7
+++ library/Makefile	12 Jul 2004 22:23:42 -0000
@@ -13,7 +13,7 @@
 
 CC=gcc
 CPPFLAGS = -I. -I$(JDK_INCLUDES) -I$(JDK_OS_INCLUDES)
-CFLAGS +=-fpic -D_REENTRANT
+CFLAGS +=-fpic -D_REENTRANT -D_GNU_SOURCE
 
 INSTALL_DIR = ../os/$(OS)/$(ARCH)
 


Back to the top