Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-patch] Fix for 60299: Accessibility with Binary Parser Options


This patch switches the Binary Parser Options group with its child composite. This gets rid of an unnamed composite between the controls and the group so that a screen reader can read the name of the group before the control. Now you can't see the Binary Parser Options group unless you select a parser that has some options.

Also externalized some dialog titles accessed by Browse buttons.

Tested on Windows and Linux.

Thanks,
Tanya
Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/ChangeLog,v
retrieving revision 1.502
diff -u -r1.502 ChangeLog
--- ChangeLog	24 Jun 2004 16:44:45 -0000	1.502
+++ ChangeLog	24 Jun 2004 19:17:49 -0000
@@ -1,3 +1,13 @@
+2004-06-24 Tanya Wolff
+	Fix for PR 60299: Accessibility: Lost children in Binary Parser properties dialog
+	Switched the binary parsers Options group with its child composite so the
+	group is read before the controls in the group.
+	Externalized a few dialog titles.
+	* src/org/eclipse/cdt/ui/dialogs/BinaryParserBock.java
+	* src/org/eclipse/cdt/ui/dialogs/CygwinBinaryParserPage.java
+	* src/org/eclipse/cdt/ui/dialogs/GNUElfBinaryParserPage.java
+	* src/org/eclipse/cdt/ui/dialogs/BinaryParserBock.java
+	
 2004-06-24 Hoda Amer
 	A small fix to the New Class Wizard "link to file" option.
 	
Index: src/org/eclipse/cdt/ui/dialogs/BinaryParserBlock.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/dialogs/BinaryParserBlock.java,v
retrieving revision 1.16
diff -u -r1.16 BinaryParserBlock.java
--- src/org/eclipse/cdt/ui/dialogs/BinaryParserBlock.java	8 Jun 2004 17:40:04 -0000	1.16
+++ src/org/eclipse/cdt/ui/dialogs/BinaryParserBlock.java	24 Jun 2004 19:17:50 -0000
@@ -189,9 +189,9 @@
 		binaryList.setButtonsMinWidth(buttonBarWidth);
 
 		// Add the Parser UI contribution.
-		Group parserGroup = new Group(composite, SWT.SHADOW_ETCHED_IN);
-		parserGroup.setText(CUIMessages.getString("BinaryParserBlock.binaryParserOptions")); //$NON-NLS-1$
-
+		
+		Composite parserGroup = new Composite(composite, SWT.NULL);
+		
 		GridData gd = new GridData();
 		gd.heightHint = converter.convertHorizontalDLUsToPixels(150);
 		gd.horizontalAlignment = GridData.FILL;
Index: src/org/eclipse/cdt/ui/dialogs/CygwinPEBinaryParserPage.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/dialogs/CygwinPEBinaryParserPage.java,v
retrieving revision 1.6
diff -u -r1.6 CygwinPEBinaryParserPage.java
--- src/org/eclipse/cdt/ui/dialogs/CygwinPEBinaryParserPage.java	8 Jun 2004 17:40:04 -0000	1.6
+++ src/org/eclipse/cdt/ui/dialogs/CygwinPEBinaryParserPage.java	24 Jun 2004 19:17:50 -0000
@@ -37,6 +37,7 @@
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.FileDialog;
+import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
 
@@ -143,8 +144,12 @@
 	 * 
 	 * @see org.eclipse.jface.dialogs.IDialogPage#createControl(org.eclipse.swt.widgets.Composite)
 	 */
-	public void createControl(Composite parent) {
-		Composite comp = ControlFactory.createCompositeEx(parent, 2, GridData.FILL_HORIZONTAL);
+	public void createControl(Composite composite) {
+		Group comp = new Group(composite, SWT.SHADOW_ETCHED_IN);
+		comp.setText(CUIMessages.getString("BinaryParserBlock.binaryParserOptions")); //$NON-NLS-1$
+		
+		comp.setLayout(new GridLayout(2, true));
+		comp.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
 		((GridLayout) comp.getLayout()).makeColumnsEqualWidth = false;
 
 		Label label = ControlFactory.createLabel(comp, CUIMessages.getString("BinaryParserPage.label.addr2lineCommand")); //$NON-NLS-1$
@@ -170,7 +175,7 @@
 
 			private void handleAddr2LineButtonSelected() {
 				FileDialog dialog = new FileDialog(getShell(), SWT.NONE);
-				dialog.setText("addr2line Command"); //$NON-NLS-1$
+				dialog.setText(CUIMessages.getString("BinaryParserPage.label.addr2lineCommand")); //$NON-NLS-1$
 				String command = fAddr2LineCommandText.getText().trim();
 				int lastSeparatorIndex = command.lastIndexOf(File.separator);
 				if (lastSeparatorIndex != -1) {
@@ -208,7 +213,7 @@
 
 			private void handleCPPFiltButtonSelected() {
 				FileDialog dialog = new FileDialog(getShell(), SWT.NONE);
-				dialog.setText("c++filt Command"); //$NON-NLS-1$
+				dialog.setText(CUIMessages.getString("BinaryParserPage.label.cppfiltCommand")); //$NON-NLS-1$
 				String command = fCPPFiltCommandText.getText().trim();
 				int lastSeparatorIndex = command.lastIndexOf(File.separator);
 				if (lastSeparatorIndex != -1) {
@@ -246,7 +251,7 @@
 
 			private void handleCygPathButtonSelected() {
 				FileDialog dialog = new FileDialog(getShell(), SWT.NONE);
-				dialog.setText("cygpath Command"); //$NON-NLS-1$
+				dialog.setText(CUIMessages.getString("BinaryParserPage.label.cygpathCommand")); //$NON-NLS-1$
 				String command = fCygPathCommandText.getText().trim();
 				int lastSeparatorIndex = command.lastIndexOf(File.separator);
 				if (lastSeparatorIndex != -1) {
Index: src/org/eclipse/cdt/ui/dialogs/GNUElfBinaryParserPage.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/dialogs/GNUElfBinaryParserPage.java,v
retrieving revision 1.7
diff -u -r1.7 GNUElfBinaryParserPage.java
--- src/org/eclipse/cdt/ui/dialogs/GNUElfBinaryParserPage.java	21 Jun 2004 22:08:09 -0000	1.7
+++ src/org/eclipse/cdt/ui/dialogs/GNUElfBinaryParserPage.java	24 Jun 2004 19:17:50 -0000
@@ -37,6 +37,7 @@
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.FileDialog;
+import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
 
@@ -141,9 +142,12 @@
 	 * @see org.eclipse.jface.dialogs.IDialogPage#createControl(org.eclipse.swt.widgets.Composite)
 	 */
 	public void createControl(Composite parent) {
-		Composite comp = ControlFactory.createCompositeEx(parent, 2, GridData.FILL_HORIZONTAL);
+		Group comp = new Group(parent, SWT.SHADOW_ETCHED_IN);
+		comp.setText(CUIMessages.getString("BinaryParserBlock.binaryParserOptions")); //$NON-NLS-1$
+		comp.setLayout(new GridLayout(2, true));
+		comp.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
 		((GridLayout) comp.getLayout()).makeColumnsEqualWidth = false;
-
+		
 		Label label = ControlFactory.createLabel(comp, CUIMessages.getString("BinaryParserPage.label.addr2lineCommand")); //$NON-NLS-1$
 		GridData gd = new GridData();
 		gd.horizontalSpan = 2;
@@ -167,7 +171,7 @@
 
 			private void handleAddr2LineButtonSelected() {
 				FileDialog dialog = new FileDialog(getShell(), SWT.NONE);
-				dialog.setText("addr2line Command"); //$NON-NLS-1$
+				dialog.setText(CUIMessages.getString("BinaryParserPage.label.addr2lineCommand")); //$NON-NLS-1$
 				String command = fAddr2LineCommandText.getText().trim();
 				int lastSeparatorIndex = command.lastIndexOf(File.separator);
 				if (lastSeparatorIndex != -1) {
@@ -205,7 +209,7 @@
 
 			private void handleCPPFiltButtonSelected() {
 				FileDialog dialog = new FileDialog(getShell(), SWT.NONE);
-				dialog.setText("c++filt Command"); //$NON-NLS-1$
+				dialog.setText(CUIMessages.getString("BinaryParserPage.label.cppfiltCommand")); //$NON-NLS-1$
 				String command = fCPPFiltCommandText.getText().trim();
 				int lastSeparatorIndex = command.lastIndexOf(File.separator);
 				if (lastSeparatorIndex != -1) {

Back to the top