| [cdt-patch] Fix for the bugzilla report #65576 |
The attached file 'patch.txt' contains the fix for bugzilla report #65576. Currently Make,GCC,GAS,GLD Error parsers do not return 'true' even if they parse error output successfully. This patch fixes the problem.
Thanks,
-Sunil.
<<patch.txt>>
Index: GASErrorParser.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/GASErrorParser.java,v
retrieving revision 1.4
diff -u -r1.4 GASErrorParser.java
--- GASErrorParser.java 1 Mar 2004 22:16:48 -0000 1.4
+++ GASErrorParser.java 4 Jun 2004 00:56:22 -0000
@@ -48,6 +48,7 @@
desc = fileName + " " + desc; //$NON-NLS-1$
}
eoParser.generateMarker(file, num, desc, severity, null);
+ return true;
}
} catch (IndexOutOfBoundsException e) {
}
Index: GCCErrorParser.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/GCCErrorParser.java,v
retrieving revision 1.12
diff -u -r1.12 GCCErrorParser.java
--- GCCErrorParser.java 16 Mar 2004 21:12:57 -0000 1.12
+++ GCCErrorParser.java 4 Jun 2004 00:56:22 -0000
@@ -223,6 +223,7 @@
}
eoParser.generateMarker(file, num, desc, severity, varName);
+ return true;
} else {
if (line.startsWith("In file included from ")) { //$NON-NLS-1$
eoParser.appendToScratchBuffer(line);
Index: GLDErrorParser.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/GLDErrorParser.java,v
retrieving revision 1.5
diff -u -r1.5 GLDErrorParser.java
--- GLDErrorParser.java 1 Mar 2004 22:16:48 -0000 1.5
+++ GLDErrorParser.java 4 Jun 2004 00:56:22 -0000
@@ -47,6 +47,7 @@
desc = fileName + " " + desc; //$NON-NLS-1$
}
eoParser.generateMarker(file, 0, desc, IMarkerGenerator.SEVERITY_ERROR_RESOURCE, null);
+ return true;
} else if (buf.endsWith("ld")){ //$NON-NLS-1$
// By default treat the condition as fatal/error, unless marked as a warning
int errorType = IMarkerGenerator.SEVERITY_ERROR_RESOURCE;
@@ -62,6 +63,7 @@
}
eoParser.generateMarker(file, 0, desc, errorType, null);
+ return true;
}
}
return false;
Index: MakeErrorParser.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt-core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/errorparsers/MakeErrorParser.java,v
retrieving revision 1.6
diff -u -r1.6 MakeErrorParser.java
--- MakeErrorParser.java 4 Sep 2003 15:37:08 -0000 1.6
+++ MakeErrorParser.java 4 Jun 2004 00:56:22 -0000
@@ -68,6 +68,7 @@
} else {
eoParser.generateMarker(null, -1, msg, IMarkerGenerator.SEVERITY_ERROR_BUILD, null);
}
+ return true;
}
}
return false;