Committed: [cdt-patch] Managed Build System - Enumerated option referenc

[Sean Evoy <sevoy@xxxxxxxxxx>]

Thanks for catching that, Leo.

Sean Evoy
Rational Software - IBM Software Group
Ottawa, Ontario, Canada

"Treggiari, Leo" <leo.treggiari@xxxxxxxxx>
Sent by: cdt-patch-admin@xxxxxxxxxxx

05/11/2004 04:06 PM

Please respond to
cdt-patch

To	<cdt-patch@xxxxxxxxxxx>
cc
Subject	RE: [cdt-patch] Managed Build System - Enumerated option reference - Fix for PR 61596

Hi Sean,
 
Yes, I saw your changes and
they look good.  But I believe there is a scenario that the changes
didn’t address.
 
1.        Create
a new managed build project named Test.  In the example below, it
is an “Executable (Cygwin)”.
2.        Open
the project properties, select the C/C++ Build page and change the Debugging
option to “Minimal (-g1)”.
3.        Save
the changes and exit Eclipse.
 
The resulting .cdtbuild file
is below.  Notice the optionReferences in the Configuration->toolReference
that were modified in step 2 above.  These optionReferences are using
the “name” rather than the “Id” of the enumerated value.  My patch
addresses this.
 
Regards,
Leo
 
<?xml version="1.0"
encoding="UTF-8"?>
<?fileVersion 2.0.0?>
 
<ManagedProjectBuildInfo>
<target id="Test.cdt.managedbuild.target.gnu.cygwin.exe.1178135125"
name="Executable (Cygwin)" parent="cdt.managedbuild.target.gnu.cygwin.exe"
isAbstract="false" artifactName="Test" isTest="false"
errorParsers="org.eclipse.cdt.core.MakeErrorParser;org.eclipse.cdt.core.GCCErrorParser;org.eclipse.cdt.core.GLDErrorParser;org.eclipse.cdt.core.GASErrorParser">
<configuration id="cdt.managedbuild.config.gnu.cygwin.exe.debug.1244696685"
name="Debug" parent="cdt.managedbuild.config.gnu.cygwin.exe.debug">
<toolReference id="cdt.managedbuild.tool.gnu.c.compiler"
command="gcc" outputPrefix="" outputFlag="-o">
<optionReference id="gnu.c.compiler.option.optimization.level"
defaultValue="None (-O0)"/>
<optionReference id="gnu.c.compiler.option.debugging.level"
defaultValue="Minimal (-g1)"/>
</toolReference>
<toolReference id="cdt.managedbuild.tool.gnu.cpp.compiler"
command="g++" outputPrefix="" outputFlag="-o">
<optionReference id="gnu.cpp.compiler.option.optimization.level"
defaultValue="gnu.cpp.compiler.optimization.level.none"/>
<optionReference id="gnu.cpp.compiler.option.debugging.level"
defaultValue="gnu.cpp.compiler.debugging.level.max"/>
</toolReference>
</configuration>
<configuration id="cdt.managedbuild.config.gnu.cygwin.exe.release.1100325044"
name="Release" parent="cdt.managedbuild.config.gnu.cygwin.exe.release">
<toolReference id="cdt.managedbuild.tool.gnu.c.compiler"
command="gcc" outputPrefix="" outputFlag="-o">
<optionReference id="gnu.c.compiler.option.optimization.level"
defaultValue="gnu.c.optimization.level.most"/>
<optionReference id="gnu.c.compiler.option.debugging.level"
defaultValue="gnu.c.debugging.level.none"/>
</toolReference>
<toolReference id="cdt.managedbuild.tool.gnu.cpp.compiler"
command="g++" outputPrefix="" outputFlag="-o">
<optionReference id="gnu.cpp.compiler.option.optimization.level"
defaultValue="gnu.cpp.compiler.optimization.level.most"/>
<optionReference id="gnu.cpp.compiler.option.debugging.level"
defaultValue="gnu.cpp.compiler.debugging.level.none"/>
</toolReference>
</configuration>
</target>
</ManagedProjectBuildInfo>
 
-----Original Message-----
From: cdt-patch-admin@xxxxxxxxxxx [mailto:cdt-patch-admin@xxxxxxxxxxx]
On Behalf Of Sean Evoy
Sent: Tuesday, May 11, 2004 1:14 PM
To: cdt-patch@xxxxxxxxxxx
Subject: Re: [cdt-patch] Managed Build System - Enumerated option reference
- Fix for PR 61596
 

Leo, 
I have submitted work to address the issue of storing the name of the enumerated
option value in the project file instead of the ID. I switched over to
using the ID and added some logic to the project conversion routine and
project load/save to handle this. Could you check to make sure this is
sufficient for you. If not, I can revisit the design and merge in your
work. 

Sean Evoy
Rational Software - IBM Software Group
Ottawa, Ontario, Canada

"Treggiari, Leo" <leo.treggiari@xxxxxxxxx>
Sent by: cdt-patch-admin@xxxxxxxxxxx

05/10/2004 11:42 PM

Please respond to
cdt-patch

To	<cdt-patch@xxxxxxxxxxx>
cc
Subject	[cdt-patch] Managed Build System - Enumerated option reference - Fix for PR 61596

 

Attached is the fix for PR 61596.

Regards,
Leo