Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-patch] Fw: CDT2.0 Scanner configuration discovery

Ok, I finally found some time to take a closer look at this.. sorry for the delay. see comments below.

Vladimir Hirsl wrote:

This patch contains redesigned implementation of Scanner config discovery. After Doug's inspections following changes were made: - ErrorParserManager, IErrorParser interface and ErrorParsers extension point are not used anymore. Instead, ScannerInfoConsoleParser extension point is defined with appropriate surrounding classes. - GNU specifics are now minimized to two ScannerInfoConsoleParsers one for make builder, the other for ExternalScannerInforProvider command (implemented as extension point/extension) and a cygpath translator. - The build/error parse performance is not affected in case console parsing for scanner info is disabled. - New Scanner config page for Preferences, project properties and New Make Project wizard.

I have been trying to understand just by looking at the ui page and the effects its has on the project and it is not clear how each control effect scanner discovery. Is the control at the top of the page like a master switch for every thing? If so then it needs to disable all other controls in the page. Also, are there other part of this page that need to do the same? ( Is 'Command output parser options' and 'Generate scanner info command' not related? )


Limitations/future work: - relative paths are not handled properly yet, currently being worked on,
- changes to Paths and Symbols page UI to follow.

- Documentation (user and ISV) ;-)

PS... I think were getting close to commiting this...

Thanks
Dave

Please let me know if the work can be further improved, I am eager to see it in CVS.

Thanks,
Vmir

P.S. Huge thanks to Doug for many valuable comments.



Back to the top