RE: [cdt-patch] ToolReference refactor

["Lott, Jeremiah" <jeremiah.lott@xxxxxxxxxxx>]

I did a clean get from cvs and errors no longer occur.  Not sure what
was happening.  I was having some general problems with my dev
environment so probably related to that.  Sorry about the false alarm.

  Jeremiah

-----Original Message-----
From: John Camelon [mailto:jcamelon@xxxxxxxxxx] 
Sent: Thursday, February 19, 2004 12:16 PM
To: cdt-patch@xxxxxxxxxxx
Subject: RE: [cdt-patch] ToolReference refactor


What are the errors?  Do they happen on a clean get from CVS? 

JohnC
www.eclipse.org/cdt

cdt-patch-admin@xxxxxxxxxxx wrote on 02/19/2004 07:07:10 AM:

> Ran tests on windows.  All the managed build tests passed.  I got 3 
> errors in the indexer tests, but I don't think they are related to 
> what I changed.  Maybe something is setup wrong on my machine?
> 
>   Jeremiah
> 
> -----Original Message-----
> From: Lott, Jeremiah
> Sent: Wednesday, February 18, 2004 6:28 PM
> To: cdt-patch@xxxxxxxxxxx
> Subject: [cdt-patch] ToolReference refactor
> 
> 
> In working on my prototype I came across a small refactor to managed 
> build I thought might be generally useful.  It regards tool reference.

> Currently the class 
> org.eclipse.cdt.managedbuilder.internal.core.ToolReference is used to 
> "wrap" a tool instance.  Many of the methods are simple delegators, 
> some override the values based on the .cdtbuild file to reflect user 
> specified changes.  What I did was make an abstract class in 
> managedbuilder.core that implements ITool and delegates all of its 
> methods to a wrapped ITool instance.  I then changed the existing 
> class to extend this abstract class, and removed the simple delegators

> as they are now unnecessary.  I also extended the abstract class in my

> prototype, but I'm not submitting that.  This doesn't have any user 
> visible effect, it just makes it easier for people like me to make 
> customizations to managed build.
> 
> The main thing I'm not sure about is the names.  I called my abstract 
> class org.eclipse.cdt.managedbuilder.core.ToolReference.  I renamed 
> the existing ToolReference class to 
> org.eclipse.cdt.managedbuilder.internal.core.ConfigToolReference.
> 
> Sean (and anyone else interested in managed build), do you think this 
> refactoring is useful?  If you want different names for the classes, 
> just let me know and I'll regenerate the patch.  If you don't think
this
> is generally useful, so be it.   I'll just withdraw the patch.
> 
> I'm having problems getting the test suite to run.  I'll try and fix 
> that tomorrow, but I wanted to at least get this out there for review.
> 
>   Jeremiah Lott
>   TimeSys Corporation _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-patch

_______________________________________________
cdt-patch mailing list
cdt-patch@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/cdt-patch