Re: [cdt-patch] CDT 1_2 Version: Indexer patch for Bug 51232

["Thomas Fletcher" <thomasf@xxxxxxx>]

Bogdan Gheorghe <gheorghe@xxxxxxxxxx> said:
> 
> This patch adds a layer of separation between the indexer and the parser
> by running the parser in its own thread. This allows the indexer to
> finish all jobs regardless of the individual parser outcomes. Also fixed
> a potential EOF bug while reading stored indexes. 
> 
> This patch is for 1.2 only (a separate patch is coming for 2.0). 

You win some, you loose some =;-)

This patch is awesome in terms of fixing the stability problem, 
unfortunately because we are now creating/destroying a new thread
all of the time, indexing is 5-10 times slower (I'll get some 
real timings for you).

Personally for 1.2 I'll take stability over speed, but for 2.0
we might want to look at a speedier alternative.  This also has
an effect on the project import phase since now with more threads
contending and scheduling activity going on, projects take longer
to import.

Thanks for the patch however, the improved stability is good and 
once the project is initially indexed, then life is good.
 Thomas