Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-patch] Fix for bug 51373: NPE when trying to instantiate a CBuildConsole with non null id

Here it is again.

Thanks,
Vmir






John Camelon/Ottawa/IBM
02/10/2004 04:22 PM

To
Vladimir Hirsl/Ottawa/IBM@IBMCA
cc

Subject
Re: [cdt-patch] Fix for bug 51373: NPE when trying to instantiate a 
CBuildConsole with non null id





Please resubmit w/ChangeLog updated.  Thanks

JohnC
www.eclipse.org/cdt

cdt-patch-admin@xxxxxxxxxxx wrote on 02/09/2004 10:29:37 AM:

> Trivial fix, no JUnit tests created.
> 
> Thanks,
> Vladimir Hirsl
> Rational Software - IBM Software Group
> Ottawa, Ontario, Canada
> 
> [attachment "51373.core-patch.txt" deleted by John Camelon/Ottawa/IBM] 
Index: ChangeLog
===================================================================
retrieving revision 1.211
diff -u -r1.211 ChangeLog
--- ChangeLog	6 Feb 2004 17:29:36 -0000	1.211
+++ ChangeLog	10 Feb 2004 18:53:25 -0000
@@ -1,3 +1,6 @@
+2004-02-10 Vladimir Hirsl
+	Fix for PR# 51373: NPE when trying to instantiate a CBuildConsole with non null id
+
 2004-02-06 Hoda Amer
 	Fix for Bug#51208: NullPointerException in CModelBuilder
 	
Index: src/org/eclipse/cdt/core/CCorePlugin.java
===================================================================
retrieving revision 1.42
diff -u -r1.42 CCorePlugin.java
--- src/org/eclipse/cdt/core/CCorePlugin.java	27 Jan 2004 01:21:18 -0000	1.42
+++ src/org/eclipse/cdt/core/CCorePlugin.java	10 Feb 2004 18:53:40 -0000
@@ -448,7 +448,7 @@
 					IConfigurationElement[] configElements = extensions[i].getConfigurationElements();
 					for (int j = 0; j < configElements.length; j++) {
 						String builderID = configElements[j].getAttribute("builderID");
-						if ((id == null && builderID == null) || (id != null && builderID.equals(id))) {
+						if ((id == null && builderID == null) || (id != null && id.equals(builderID))) {
 							return (IConsole) configElements[j].createExecutableExtension("class");
 						}
 					}

Back to the top