Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-patch] Fwd: Re: [cdt-dev] EditorUtility.getStorage(IBinary)

> 
> If there's anything worse than being a director, it's being a director and 
> attempting to get real work done. I must have died on the way in to work 
> today and gone to hell or something. :) Regardless, here's what the changes 
> ended up looking like for 1.2.1. I don't know if this has been an area of 
> big churn on 2.0. If not, maybe it's helpful.
> 
> With these changes to CDT, we successfully subclassed ElfParser and 
> overrode the new getViewableContents method to do our special magic for 
> what shows up when you double click a binary in Xtensa Xplorer. That makes 
> me think it works. I like not having to go in and hack EditorUtility (like 
> we did last time.)
> 
> Some review of the creation of IBuffers by Binary is appreciated. Totally 
> opaque to me, I just took a stab at it, might be leaking like a seive.
> 

Question:
- did you want this for 1.2.1 ?
  because it is a lot(too much) of changes (breaking interfaces etc ...) for that
  late in the game in the 1.2.1 branch.

Definitely head(2.x) material.  I see the general idea, I want to massage it
a little before commiting to the head.


Merci buckets(thanks).



Back to the top