Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Applied [HEAD] Re: [cdt-patch] Symbol Table storage changes

Third time's a charm!

Cheers,
JohnC




Andrew Niefer/Ottawa/IBM@IBMCA 
Sent by: cdt-patch-admin@xxxxxxxxxxx
01/15/2004 05:30 PM
Please respond to
cdt-patch@xxxxxxxxxxx


To
cdt-patch@xxxxxxxxxxx
cc

Subject
Re: [cdt-patch] Symbol Table storage changes






updated and resubmitted





Andrew Niefer/Ottawa/IBM@IBMCA 
Sent by: cdt-patch-admin@xxxxxxxxxxx
01/13/2004 03:53 PM
Please respond to
cdt-patch


To
cdt-patch@xxxxxxxxxxx
cc

Subject
Re: [cdt-patch] Symbol Table storage changes






This patch replaces the last patch I sent.

For normal lookups in the symbol table, a HashMap is faster than the tree 
map, but for prefix lookups the TreeMap is faster.  So we are now using 
the HashMap for normal parses, and we use the TreeMap in the parse mode 
used by content assist.

Note that with these changes the results returned by the IASTNode.lookup 
function used by content assist are now in predictable order:  they are 
first sorted in the order of the scopes visited during the lookup and then 


they are sorted alphabetically

Core:
        Modified symbol table constructor to take a ParseMode as a 
parameter.
        Modified symbol table to use a TreeMap instead of HashMap when 
ParseMode is CONTEXTUAL_PARSE
        Modified ASTNode.lookup to throw ASTNotImplementedException if 
called when ParseMode is not CONTEXTUAL_PARSE

Core.test:
        Moved testBug48307_FriendFunction_1 & 
testBug48307_FriendFunction_2 to ContextualParseTest
        Updated ContextualParseTest now that the order of prefix lookup 
results is predictable.

Core.UI:
        Updated CompletionEngine to catch ASTNotImplementedException from 
IASTNode.lookup

tested on windows & linux

-Andrew

[attachment "01.13.04.core.txt" deleted by Andrew Niefer/Ottawa/IBM] 
[attachment "01.13.04.core.test.txt" deleted by Andrew Niefer/Ottawa/IBM] 
[attachment "01.13.04.ui.txt" deleted by Andrew Niefer/Ottawa/IBM] 
[attachment "01.15.04.core.txt" deleted by John Camelon/Ottawa/IBM] 
[attachment "01.15.04.core.test.txt" deleted by John Camelon/Ottawa/IBM] 
[attachment "01.15.04.ui.txt" deleted by John Camelon/Ottawa/IBM] 



Back to the top