[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
[cdt-patch] Solution to bug#43524 : Removing a define from a .c file causes issues in the outline
|
UI:
Fix
for bug#43524 : Removing a define from a .c file causes issues in the outline
There was an unnecessary check before
the call to reconcile() in CReconcilingStrategy
that did not always work.
Multiple calls to reconcile() will have
no effect after the first update of the file.
Hoda Amer
Staff Software Engineer
Rational Software - IBM Software Group
Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/ChangeLog,v
retrieving revision 1.196
diff -u -r1.196 ChangeLog
--- ChangeLog 29 Sep 2003 14:56:38 -0000 1.196
+++ ChangeLog 30 Sep 2003 14:04:33 -0000
@@ -1,3 +1,6 @@
+2003-09-30 Hoda Amer
+ - Fix for bug#43524 : Removing a define from a .c file causes issues in the outline
+
2003-09-29 Hoda Amer
- Fixed Help IDs for C_Editor preference tabs.
Index: src/org/eclipse/cdt/internal/ui/text/CReconcilingStrategy.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/CReconcilingStrategy.java,v
retrieving revision 1.3
diff -u -r1.3 CReconcilingStrategy.java
--- src/org/eclipse/cdt/internal/ui/text/CReconcilingStrategy.java 5 Apr 2003 06:33:37 -0000 1.3
+++ src/org/eclipse/cdt/internal/ui/text/CReconcilingStrategy.java 30 Sep 2003 14:04:35 -0000
@@ -25,7 +25,6 @@
private CContentOutlinePage fOutliner;
- private int fLastRegionOffset;
private ITextEditor fEditor;
private IWorkingCopyManager fManager;
private IDocumentProvider fDocumentProvider;
@@ -34,7 +33,6 @@
public CReconcilingStrategy(CEditor editor) {
fOutliner= editor.getOutlinePage();
- fLastRegionOffset = Integer.MAX_VALUE;
fEditor= editor;
fManager= CUIPlugin.getDefault().getWorkingCopyManager();
fDocumentProvider= CUIPlugin.getDefault().getDocumentProvider();
@@ -58,14 +56,7 @@
* @see IReconcilingStrategy#reconcile(region)
*/
public void reconcile(IRegion region) {
- // We use a trick to avoid running the reconciler multiple times
- // on a file when it gets changed. This is because this gets called
- // multiple times with different regions of the file, we do a
- // complete parse on the first region.
- if(region.getOffset() <= fLastRegionOffset) {
- reconcile();
- }
- fLastRegionOffset = region.getOffset();
+ reconcile();
}