Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cdt-patch] Mea Culpa

Okay,
I slipped some bad code into the test for the changes I made in support of 
bug 43051. In the "testScannerInfoInterface" test, the expected return 
value for the first include path will cause a problem on Win32. I 
foolishly converted all the strings to OS-specific versions, but the first 
path returned is a built-in. The managed build system treats these as 
absolute and in the proper format.

Sean Evoy
Rational Software - IBM Software Group
Ottawa, Ontario, Canada
Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core.tests/ChangeLog,v
retrieving revision 1.113
diff -u -r1.113 ChangeLog
--- ChangeLog	25 Sep 2003 14:26:33 -0000	1.113
+++ ChangeLog	25 Sep 2003 18:58:04 -0000
@@ -1,3 +1,11 @@
+2003-09-25 Sean Evoy
+	Corrected an error in the "testScannerInfoInterface" expected include paths. The
+	first path is a built-in, so the build manager does not actually modify the path to be
+	OS-specific. This did not cause a problem on Linux, but failed on Win32 platforms. 
+	There was no real problem in the code, just in the test.
+	* build/org/eclipse/cdt/core/build/managed/tests/ManagedBuildTests.java
+
+
 2003-09-24 Hoda Amer
     Added testNewTypeId(), testCastExpression(), testPostfixDynamicCast(), 
     testPostfixReinterpretCast(), testPostfixStaticCast(), and testPostfixConstCast() 
Index: build/org/eclipse/cdt/core/build/managed/tests/ManagedBuildTests.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core.tests/build/org/eclipse/cdt/core/build/managed/tests/ManagedBuildTests.java,v
retrieving revision 1.8
diff -u -r1.8 ManagedBuildTests.java
--- build/org/eclipse/cdt/core/build/managed/tests/ManagedBuildTests.java	25 Sep 2003 03:19:31 -0000	1.8
+++ build/org/eclipse/cdt/core/build/managed/tests/ManagedBuildTests.java	25 Sep 2003 18:58:05 -0000
@@ -155,7 +155,8 @@
 	public void testScannerInfoInterface(){
 		// These are the expected path settings
 		final String[] expectedPaths = new String[4];
-		expectedPaths[0] = (new Path("/usr/gnu/include")).toOSString();
+		// This first path is a built-in, so it will not be manipulated by build manager
+		expectedPaths[0] = "/usr/gnu/include";
 		expectedPaths[1] = (new Path("/usr/include")).toOSString();
 		expectedPaths[2] = (new Path("/opt/gnome/include")).toOSString();
 		expectedPaths[3] = (new Path("C:\\home\\tester/include")).toOSString();

Back to the top