Re: [cdt-patch] Re: Updated drag patch

[Keith Campbell <keithc@xxxxxxxxxx>]

Alain,

That's about what I expected.

I have no problem with your refactoring suggestion, in fact I had used 
that name for a while.

I saw no other issues.

Thanks again,

Keith




"Alain Magloire" <alain@xxxxxxx> 
Sent by: cdt-patch-admin@xxxxxxxxxxx
2003/09/23 10:51
Please respond to
cdt-patch@xxxxxxxxxxx


To
cdt-patch@xxxxxxxxxxx
Cc

Subject
Re: [cdt-patch] Re: Updated drag patch




> --=_mixed 004F84FC85256DAA_=
> Content-Type: text/plain; charset="US-ASCII"
> 
> Thanks, Alain.
> 
> I noticed that CView#initDragAndDrop now uses 
> org.eclipse.cdt.ui.LocalSelectionTransfer in both dragTransfers and 
> dropTransfers while the patch I submitted used 
> org.eclipse.ui.views.navigator.LocalSelectionTransfer in dropTransfers 
as 
> was the case in earlier versions. CViewDropAdapter supports 
> org.eclipse.ui.views.navigator.LocalSelectionTransfer but not 
> org.eclipse.cdt.ui.LocalSelectionTransfer.
> 
> Was this change intentional? Here's a patch to correct this.

Probably not, a side effect of "organise import" action done at the wrong 
time .. maybe.

I would say that we should refactor
org.eclipse.cdt.ui.LocalSelectionTransfer --> CLocalSelectionTransfer

To minimise this sort of things,

Any other things ?

_______________________________________________
cdt-patch mailing list
cdt-patch@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/cdt-patch