Re: [cdt-patch] Re: Updated drag patch

[Keith Campbell <keithc@xxxxxxxxxx>]

Thanks, Alain.

I noticed that CView#initDragAndDrop now uses 
org.eclipse.cdt.ui.LocalSelectionTransfer in both dragTransfers and 
dropTransfers while the patch I submitted used 
org.eclipse.ui.views.navigator.LocalSelectionTransfer in dropTransfers as 
was the case in earlier versions. CViewDropAdapter supports 
org.eclipse.ui.views.navigator.LocalSelectionTransfer but not 
org.eclipse.cdt.ui.LocalSelectionTransfer.

Was this change intentional? Here's a patch to correct this.

-Keith




"Alain Magloire" <alain@xxxxxxx> 
Sent by: cdt-patch-admin@xxxxxxxxxxx
2003/09/23 10:01
Please respond to
cdt-patch@xxxxxxxxxxx


To
cdt-patch@xxxxxxxxxxx
Cc

Subject
Re: [cdt-patch] Re: Updated drag patch






> Alain,
> 
> I was just wondering when/whether you plan to apply the updated patch I 
> submitted on Monday.

Applied.

_______________________________________________
cdt-patch mailing list
cdt-patch@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/cdt-patch


Index: CView.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/cview/CView.java,v
retrieving revision 1.32
diff -u -r1.32 CView.java
--- CView.java	22 Sep 2003 04:31:34 -0000	1.32
+++ CView.java	23 Sep 2003 14:26:19 -0000
@@ -26,6 +26,7 @@
 import org.eclipse.cdt.internal.ui.StandardCElementLabelProvider;
 import org.eclipse.cdt.internal.ui.drag.DelegatingDragAdapter;
 import org.eclipse.cdt.internal.ui.drag.FileTransferDragAdapter;
+import org.eclipse.cdt.internal.ui.drag.LocalSelectionTransferDragAdapter;
 import org.eclipse.cdt.internal.ui.drag.ResourceTransferDragAdapter;
 import org.eclipse.cdt.internal.ui.drag.TransferDragSourceListener;
 import org.eclipse.cdt.internal.ui.editor.FileSearchAction;
@@ -129,9 +130,6 @@
 import org.eclipse.ui.views.framelist.GoIntoAction;
 import org.eclipse.ui.views.framelist.UpAction;
 
-
-
-
 public class CView extends ViewPart implements IMenuListener, ISetSelectionTarget,
 	IPropertyChangeListener {
 
@@ -380,7 +378,7 @@
 		TransferDragSourceListener[] dragListeners =
 			new TransferDragSourceListener[] {
 				new ResourceTransferDragAdapter(viewer),
-				new org.eclipse.cdt.internal.ui.drag.LocalSelectionTransferDragAdapter(viewer),
+				new LocalSelectionTransferDragAdapter(viewer),
 				new FileTransferDragAdapter(viewer)};
 
 		viewer.addDragSupport(ops, dragTransfers, new DelegatingDragAdapter(viewer, dragListeners));
@@ -389,7 +387,7 @@
 			new Transfer[] {
 				ResourceTransfer.getInstance(),
 				FileTransfer.getInstance(),
-				LocalSelectionTransfer.getInstance(),
+				org.eclipse.ui.views.navigator.LocalSelectionTransfer.getInstance(),
 				PluginTransfer.getInstance()};
 
 		viewer.addDropSupport(ops, dropTransfers, new CViewDropAdapter(viewer));