Applied [HEAD] w/modifications Re: REJECTED Re: [cdt-patch] Code Assist

[John Camelon <jcamelon@xxxxxxxxxx>]

I needed to add a ChangeLog entry to core.tests for you. 

Also, I have raised a defect to track the occasional Search JUnit failure 
that comes up from time to time, hence my delay on applying this patch. 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=43501

JohnC

cdt-patch-admin@xxxxxxxxxxx wrote on 09/22/2003 05:42:49 PM:

> 
> Resubmitted. 
> 
> Thanks, 
> Hoda Amer
> Staff Software Engineer
> Rational Software - IBM Software Group 
> 
> 
> 
> 
> 

> 
> John Camelon/Ottawa/IBM@IBMCA 
> Sent by: cdt-patch-admin@xxxxxxxxxxx 
> 09/22/2003 10:53 AM 
> Please respond to cdt-patch 
> 
> 
>         To:        cdt-patch@xxxxxxxxxxx 
>         cc: 
>         Subject:        REJECTED Re: [cdt-patch] Code
> Assist bug fixes
> 
> 
> 
> 
> Deja vu all over again!  This patch has the same 
> problem as Andrew's. 
> 
> JUnit runs clean on Windows, but we get a failure on 
> Linux.  Both JREs are 
> 
> 1.3. 
> 
> The offending null object is an array called results. 
>   assertEquals(results.length, 7); 
> 
> This looks similar to the problems Bogdan had 
> previously in one of his 
> tests, maybe he could shed some light on what's going on.
> 
> java.lang.NullPointerException
>        at 
> org.eclipse.cdt.core.codeassist.tests.
> CompletionProposalsTest.
> testCompletionProposals(CompletionProposalsTest.java:119)
>        at java.lang.reflect.Method.invoke(Native Method)
>        at junit.framework.TestCase.runTest(TestCase.java:154)
>        at junit.framework.TestCase.runBare(TestCase.java:127)
>        at junit.framework.TestResult$1.
> protect(TestResult.java:106)
>        at junit.framework.TestResult.
> runProtected(TestResult.java:124)
>        at junit.framework.TestResult.run(TestResult.java:109)
>        at junit.framework.TestCase.run(TestCase.java:118)
>        at junit.framework.TestSuite.runTest(TestSuite.java:208)
>        at junit.framework.TestSuite.run(TestSuite.java:203)
>        at junit.framework.TestSuite.runTest(TestSuite.java:208)
>        at junit.framework.TestSuite.run(TestSuite.java:203)
>        at 
> org.eclipse.cdt.core.suite.AutomatedIntegrationSuite.
> run(AutomatedIntegrationSuite.java:116)
>        at 
> org.eclipse.jdt.internal.junit.runner.
> RemoteTestRunner.runTests(RemoteTestRunner.java:392)
>        at 
> org.eclipse.jdt.internal.junit.runner.
> RemoteTestRunner.run(RemoteTestRunner.java:276)
>        at 
> org.eclipse.pde.internal.junit.ui.
> RemotePluginTestRunner.main(RemotePluginTestRunner.java:30)
>        at 
> org.eclipse.pde.internal.junit.ui.UITestApplication.
> runEventLoop(UITestApplication.java:35)
>        at org.eclipse.ui.internal.Workbench.
> run(Workbench.java:1385)
>        at 
> org.eclipse.core.internal.boot.InternalBootLoader.
> run(InternalBootLoader.java:858)
>        at org.eclipse.core.boot.BootLoader.
> run(BootLoader.java:431)
>        at EclipseRuntimeLauncher.
> main(EclipseRuntimeLauncher.java:24)
> 
> 
> Fix this and give it another shot. 
> 
> 
> JohnC
> 
> cdt-patch-admin@xxxxxxxxxxx wrote on 09/19/2003 04:14:52 PM:
> 
> > 
> > Core : 
> >         Solution to bug#43162 : Code Assist not 
> showing the right 
> > return value: 
> >         Saved a function return value string in the
> BasicSearchMatch 
> object. 
> >         Created a new package org.eclipse.cdt.
> internal.core.parser.util 
> and 
> >         added ASTUtil class with static methods to 
> help convert an 
> > ASTFunction 
> >         return type from IASTAbstractDeclaration to
> String. Note that 
> this was
> >         previously implemented in the 
> CModelBuilder. I just moved it
> > to a common 
> >         library for others (BasicSearchMatch) to use. 
> > UI: 
> >         Solutions to 
> >         bug#43162 : Code Assist not showing the 
> right return value 
> >         Bug#43145 : foo function still showing in 
> Code Assist even 
> > if "f" is deleted 
> >         Bug#42810 : Code Assist adding characters 
> after pressing <enter> 
> 
> >         Bug#42861 : Code Assist should be case insensitive. 
> > 
> > Tests: 
> >         Solution to bug#43162 : Code Assist not 
> showing the right 
> > return value. 
> >         Solution to Bug#42861 : Code Assist should 
> be case insensitive. 
> >         Modified the CompletionProposalsTest to 
> include upper and lower 
> cases
> >         and to include functions with different 
> return values. 
> > 
> >         Sorry John, but the rest are visual bugs 
> and could not add 
> > test cases for them. 
> > 
> > Thanks, 
> > Hoda Amer
> > Staff Software Engineer
> > Rational Software - IBM Software Group 
> > 
> > [attachment "core.sep.19.txt" deleted by John 
> Camelon/Ottawa/IBM] 
> > [attachment "tests.sep.19.txt" deleted by John 
> Camelon/Ottawa/IBM] 
> > [attachment "ui.sep.19.txt" deleted by John 
> Camelon/Ottawa/IBM] 
> _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-patch
> [attachment "ui.sep.20.txt" deleted by John 
> Camelon/Ottawa/IBM] [attachment "core.sep.20.txt" 
> deleted by John Camelon/Ottawa/IBM] [attachment 
> "tests.sep.20.txt" deleted by John Camelon/Ottawa/IBM]