REJECTED Re: [cdt-patch] fix bug43327 Code Complete finds local variable

[John Camelon <jcamelon@xxxxxxxxxx>]

JUnit runs clean on Windows, but we get a failure on Linux.  Both JREs are 
1.3. 

The offending null object is an array called results. 
   assertEquals(results.length, 7); 

This looks similar to the problems Bogdan had previously in one of his 
tests, maybe he could shed some light on what's going on.

java.lang.NullPointerException
        at 
org.eclipse.cdt.core.codeassist.tests.CompletionProposalsTest.testCompletionProposals(CompletionProposalsTest.java:119)
        at java.lang.reflect.Method.invoke(Native Method)
        at junit.framework.TestCase.runTest(TestCase.java:154)
        at junit.framework.TestCase.runBare(TestCase.java:127)
        at junit.framework.TestResult$1.protect(TestResult.java:106)
        at junit.framework.TestResult.runProtected(TestResult.java:124)
        at junit.framework.TestResult.run(TestResult.java:109)
        at junit.framework.TestCase.run(TestCase.java:118)
        at junit.framework.TestSuite.runTest(TestSuite.java:208)
        at junit.framework.TestSuite.run(TestSuite.java:203)
        at junit.framework.TestSuite.runTest(TestSuite.java:208)
        at junit.framework.TestSuite.run(TestSuite.java:203)
        at 
org.eclipse.cdt.core.suite.AutomatedIntegrationSuite.run(AutomatedIntegrationSuite.java:116)
        at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:392)
        at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:276)
        at 
org.eclipse.pde.internal.junit.ui.RemotePluginTestRunner.main(RemotePluginTestRunner.java:30)
        at 
org.eclipse.pde.internal.junit.ui.UITestApplication.runEventLoop(UITestApplication.java:35)
        at org.eclipse.ui.internal.Workbench.run(Workbench.java:1385)
        at 
org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:858)
        at org.eclipse.core.boot.BootLoader.run(BootLoader.java:431)
        at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24)


Fix this and give it another shot. 

Also, from this point on, I will need to see defect numbers in the 
ChangeLog/patch summary, as we should 
only be fixing the appropriately triaged defects.

Thanks,
JohnC

cdt-patch-admin@xxxxxxxxxxx wrote on 09/19/2003 04:08:52 PM:

> core : 
>   - modified MatchLocator to not report local declarations when boolean 
is 
> set
>   - modified SearchEngine.search to take an additional parameter 
> "excludeLocalDeclarations"
> 
> core.tests:
>   - modified resources/cfiles/CompletionProposalsTestStart.cpp
>   - modified CompletionProposalsTest.testCompletionProposals
>   - updated calls to SearchEngine.search
> 
> ui:
>   - update calls to SearchEngine.search.  CodeCompletion passes true for 

> excludeLocalDeclarations
> 
> Andrew
> 
> [attachment "patch_09.19.03(cdt.core).txt" deleted by John 
> Camelon/Ottawa/IBM] [attachment "patch_09.19.03(cdt.core.tests).txt"
> deleted by John Camelon/Ottawa/IBM] [attachment "patch_09.19.03(cdt.
> ui).txt" deleted by John Camelon/Ottawa/IBM]