Finally Applied [HEAD] Re: Resubmitted : Re: REJECTED Re: [cdt-patch] Fi

[John Camelon <jcamelon@xxxxxxxxxx>]

You should feel shame. 
But the donuts you buy this afternoon will redeem yourself somewhat  in my 
eyes. 

Feature freeze in 4 hours!

JohnC

cdt-patch-admin@xxxxxxxxxxx wrote on 09/18/2003 05:28:57 PM:

> I feel shame.
> The symbol table changes should have had no affect on the search 
results. 
> However, the symbol table test project includes a file mail.cpp that 
never 
> parsed very well because of the inclusion of a number of system includes 

> as well as the presence of lots of expressions.
> It seems that with this patch, the parsing of expressions has improved 
> enough so that we are getting more search results out of it, including 
one 
> additional unforseen parameter reference.
> 
> I have removed this file from the search test project until such time 
that 
> tests are actually written to test it.
> 
> -Andrew
> 
> 
> 
> 
> 
> John Camelon/Ottawa/IBM@IBMCA 
> Sent by: cdt-patch-admin@xxxxxxxxxxx
> 09/18/2003 04:26 PM
> Please respond to
> cdt-patch@xxxxxxxxxxx
> 
> 
> To
> cdt-patch@xxxxxxxxxxx
> cc
> 
> Subject
> REJECTED Re: [cdt-patch] Fix ParserSymbolTable bugs
> 
> 
> 
> 
> 
> 
> 1 JUnit failure in Search ...  please fix.
> 
> junit.framework.AssertionFailedError: expected:<4> but was:<3>
>         at junit.framework.Assert.fail(Assert.java:47)
>         at junit.framework.Assert.failNotEquals(Assert.java:282)
>         at junit.framework.Assert.assertEquals(Assert.java:64)
>         at junit.framework.Assert.assertEquals(Assert.java:201)
>         at junit.framework.Assert.assertEquals(Assert.java:207)
>         at 
> org.eclipse.cdt.core.search.tests.OtherPatternTests.
> testParameterReferences(OtherPatternTests.java:238)
>         at java.lang.reflect.Method.invoke(Native Method)
>         at junit.framework.TestCase.runTest(TestCase.java:154)
>         at junit.framework.TestCase.runBare(TestCase.java:127)
>         at junit.framework.TestResult$1.protect(TestResult.java:106)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.framework.TestResult.run(TestResult.java:109)
>         at junit.framework.TestCase.run(TestCase.java:118)
>         at junit.framework.TestSuite.runTest(TestSuite.java:208)
>         at junit.framework.TestSuite.run(TestSuite.java:203)
>         at junit.framework.TestSuite.runTest(TestSuite.java:208)
>         at junit.framework.TestSuite.run(TestSuite.java:203)
>         at junit.framework.TestSuite.runTest(TestSuite.java:208)
>         at junit.framework.TestSuite.run(TestSuite.java:203)
>         at 
> org.eclipse.cdt.core.suite.AutomatedIntegrationSuite.
> run(AutomatedIntegrationSuite.java:116)
>         at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.
> runTests(RemoteTestRunner.java:392)
>         at 
> org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.
> run(RemoteTestRunner.java:276)
>         at 
> org.eclipse.pde.internal.junit.ui.RemotePluginTestRunner.
> main(RemotePluginTestRunner.java:30)
>         at 
> org.eclipse.pde.internal.junit.ui.UITestApplication.
> runEventLoop(UITestApplication.java:35)
>         at org.eclipse.ui.internal.Workbench.run(Workbench.java:1385)
>         at 
> org.eclipse.core.internal.boot.InternalBootLoader.
> run(InternalBootLoader.java:845)
>         at org.eclipse.core.boot.BootLoader.run(BootLoader.java:431)
>         at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24)
> 
> JohnC
> 
> cdt-patch-admin@xxxxxxxxxxx wrote on 09/18/2003 02:58:51 PM:
> 
> > Core :
> >         - modified Symbol table interfaces to use List & Map instead 
of 
> > LinkedList and HashMap
> >         - fixed warnings in ParserSymbolTable
> >         - fixed bug43106 - Symbol Table support needed to resolve 
types
> >         - fixed bug43156 - require ability to add implicit inheritance 

> > copy constructor
> >         - fixed bug43159 - TypeInfo.equals() not working properly
> >         - fixed bug43238 - Postfix_Subscript expressions confuse 
> function 
> > resolution
> > 
> > Tests:
> >         - removed testConditionalExpression_Bug43159 from 
> > FailedCompleteParseASTExpressionTest
> >           and uncommented it (testConditionalExpression) in 
> > CompleteParseASTExpressionTest
> >         - uncommented the following tests in 
> > CompleteParseASTExpressionTest :
> >             testPostfixSubscript, 
> >             testPostfixSubscriptA, 
> >             testPostfixSubscriptB,
> >             testPostfixSubscriptWithReferences
> >         - updated ParserSymbolTableTests to use new 
> addOperatorExpression 
> > function
> >         - added testDerivedReference, testAddCopyConstructor to 
> > ParserSymbolTableTests
> >         - fixed warning in ClassDeclarationPatternTests
> > 
> > Andrew
> > 
> > [attachment "pst_patch_09.18.03(cdt.core).txt" deleted by John 
> > Camelon/Ottawa/IBM] [attachment "pst_patch_09.18.03(cdt.core.tests).
> > txt" deleted by John Camelon/Ottawa/IBM] 
> _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-patch
> 
> [attachment "pst_patch_09.18.03(cdt.core).txt" deleted by John 
> Camelon/Ottawa/IBM] [attachment "pst_patch_09.18.03(cdt.core.tests).
> txt" deleted by John Camelon/Ottawa/IBM]