REJECTED : Re: [cdt-patch] Search Bugs (42836, 42902, 43016)

[John Camelon <jcamelon@xxxxxxxxxx>]

JUnit failure : OtherPatternTests::testNamespaceReferenceInClassBaseClause 
fails consistently. 

junit.framework.AssertionFailedError
        at junit.framework.Assert.fail(Assert.java:47)
        at junit.framework.Assert.assertTrue(Assert.java:20)
        at junit.framework.Assert.assertTrue(Assert.java:27)
        at 
org.eclipse.cdt.core.search.tests.OtherPatternTests.testNamespaceReferenceInClassBaseClause(OtherPatternTests.java:133)
        at java.lang.reflect.Method.invoke(Native Method)
        at junit.framework.TestCase.runTest(TestCase.java:154)
        at junit.framework.TestCase.runBare(TestCase.java:127)
        at junit.framework.TestResult$1.protect(TestResult.java:106)
        at junit.framework.TestResult.runProtected(TestResult.java:124)
        at junit.framework.TestResult.run(TestResult.java:109)
        at junit.framework.TestCase.run(TestCase.java:118)
        at junit.framework.TestSuite.runTest(TestSuite.java:208)
        at junit.framework.TestSuite.run(TestSuite.java:203)
        at junit.framework.TestSuite.runTest(TestSuite.java:208)
        at junit.framework.TestSuite.run(TestSuite.java:203)
        at junit.framework.TestSuite.runTest(TestSuite.java:208)
        at junit.framework.TestSuite.run(TestSuite.java:203)
        at 
org.eclipse.cdt.core.suite.AutomatedIntegrationSuite.run(AutomatedIntegrationSuite.java:115)
        at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:392)
        at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:276)
        at 
org.eclipse.pde.internal.junit.ui.RemotePluginTestRunner.main(RemotePluginTestRunner.java:30)
        at 
org.eclipse.pde.internal.junit.ui.UITestApplication.runEventLoop(UITestApplication.java:35)
        at org.eclipse.ui.internal.Workbench.run(Workbench.java:1385)
        at 
org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:845)
        at org.eclipse.core.boot.BootLoader.run(BootLoader.java:431)
        at EclipseRuntimeLauncher.main(EclipseRuntimeLauncher.java:24)


From the email : Applied [HEAD] Re: Resubmitted: Re: Rejected : Re: 
[cdt-patch] ParserFactory functions now take a ParserLanguage Parameter
>  Thank You But Please Be More Careful In The Future Thanks

My time is just as precious as yours ... run the tests before you submit a 
patch. 
Thank you, 

JohnC

cdt-patch-admin@xxxxxxxxxxx wrote on 09/12/2003 04:35:07 PM:

> This patch is for the following bugs:
> bug42836 - Navigate/search: prepopulate template classes from Outline...
> bug42902 - Search: Cannot find typedef
> bug43016 - Search: Cannot find macro declarations
> 
> Core:
> - add Typedefs to index as Types with suffix T (bug42902)
>         - added addTypedefReference to AbstractIndexer
>         - modified bestTypePrefix in AbstractIndexer
> - added TYPEDEF_DECL, TYPEDEF_SUFFIX to IIndexConstants
>         - modified acceptTypedefReference in SourceIndexerRequestor
> -Searching for Typedefs: (bug42902)
>         - modified setElementInfo in BasicSearchResultCollector
>         - added TYPEDEF to ICSearchConstants
>         - modified CSearchPattern & ClassDeclarationPattern
>         - implemented acceptTypedef* in MatchLocator
> 
> Core.tests
> - updated testIndexContents and testIndexAll and added them back into 
the 
> IndexManagerTests suite
> - modified resources/search/classDecl.cpp to include a typedef
> - added testbug42902_TypeDefs to ClassDeclarationPatternTests
> - updated testNamespaceReferenceInClassBaseClause in OtherPatternTests
> 
> UI
> - modified performAction & determineInitValuesFrom in CSearchPage
> - modified getImage in CSearchResultLabelProvider
> 
> -Andrew
> [attachment "patch_09.12.03(cdt.core).txt" deleted by John 
> Camelon/Ottawa/IBM] [attachment "patch_09.12.03(cdt.core.tests).txt"
> deleted by John Camelon/Ottawa/IBM] [attachment "patch_09.12.03(cdt.
> ui).txt" deleted by John Camelon/Ottawa/IBM]