[cdt-patch] PR 42549 Fix

["Alain Magloire" <alain@xxxxxxx>]

Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/ChangeLog,v
retrieving revision 1.159
diff -u -r1.159 ChangeLog
--- ChangeLog	4 Sep 2003 14:39:20 -0000	1.159
+++ ChangeLog	4 Sep 2003 19:05:29 -0000
@@ -1,3 +1,9 @@
+2003-09-04 Alain Magloire
+
+	Faulty logic when checking the build console preferences.
+
+	* src/org/eclipse/cdt/internal/ui/BuildConsoleManager.java
+
 2003-09-03 Andrew Niefer
 	C++ Search: Changed default sort order to be by path
 	changed search dialog to have checkboxes for Search For items.
Index: src/org/eclipse/cdt/internal/ui/BuildConsoleManager.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/BuildConsoleManager.java,v
retrieving revision 1.7
diff -u -r1.7 BuildConsoleManager.java
--- src/org/eclipse/cdt/internal/ui/BuildConsoleManager.java	12 Mar 2003 19:30:31 -0000	1.7
+++ src/org/eclipse/cdt/internal/ui/BuildConsoleManager.java	4 Sep 2003 19:05:29 -0000
@@ -118,8 +118,7 @@
 		public void flush() throws IOException {
 			Display.getDefault().syncExec(new Runnable() {
 				public void run() {
-					if (BuildConsolePreferencePage.isConsoleOnTop())
-						bringConsoleOnTop();
+					bringConsoleOnTop();
 					try {
 						int len = fDocument.getLength();
 						fDocument.replace(len, 0, readBuffer());
@@ -145,7 +144,8 @@
 							//restore focus
 							page.activate(activePart);
 						}
-					} else {
+					}
+					if (cBuild != null && BuildConsolePreferencePage.isConsoleOnTop()) {
 						page.bringToTop(cBuild);
 					}
 				} catch (PartInitException pie) {