[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[cdt-patch] Fix small bug in PST
|
fix bug in PST that causes parse failure on > 2 constructors for a given
class
Modified ParserSymbolTableTest.testConstructors to test > 2 constructors
-Andrew
Index: parser/ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core/parser/ChangeLog,v
retrieving revision 1.108
diff -u -r1.108 ChangeLog
--- parser/ChangeLog 3 Sep 2003 15:15:59 -0000 1.108
+++ parser/ChangeLog 3 Sep 2003 20:20:22 -0000
@@ -1,3 +1,6 @@
+2003-09-03 Andrew Niefer
+ fix bug in PST that prevents > 2 constructors
+
2003-09-03 John Camelon
Fixed bug41445 - QualifiedLookup succeeds where it should fail.
Index: parser/org/eclipse/cdt/internal/core/parser/pst/ParserSymbolTable.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/pst/ParserSymbolTable.java,v
retrieving revision 1.15
diff -u -r1.15 ParserSymbolTable.java
--- parser/org/eclipse/cdt/internal/core/parser/pst/ParserSymbolTable.java 2 Sep 2003 20:05:14 -0000 1.15
+++ parser/org/eclipse/cdt/internal/core/parser/pst/ParserSymbolTable.java 3 Sep 2003 20:20:26 -0000
@@ -476,7 +476,7 @@
//the first thing can be a class-name or enumeration name, but the rest
//must be functions. So make sure the newDecl is a function before even
//considering the list
- if( newSymbol.getType() != TypeInfo.t_function ){
+ if( newSymbol.getType() != TypeInfo.t_function && newSymbol.getType() != TypeInfo.t_constructor ){
return false;
}
Index: ChangeLog
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core.tests/ChangeLog,v
retrieving revision 1.74
diff -u -r1.74 ChangeLog
--- ChangeLog 3 Sep 2003 15:16:03 -0000 1.74
+++ ChangeLog 3 Sep 2003 20:20:45 -0000
@@ -1,3 +1,6 @@
+2003-09-03 Andrew Niefer
+ Modified ParserSymbolTableTest.testConstructors to test > 2 constructors
+
2003-09-03 John Camelon
Added testBug41445() to CompleteParseASTTests.java.
Index: parser/org/eclipse/cdt/core/parser/tests/ParserSymbolTableTest.java
===================================================================
RCS file: /home/tools/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ParserSymbolTableTest.java,v
retrieving revision 1.14
diff -u -r1.14 ParserSymbolTableTest.java
--- parser/org/eclipse/cdt/core/parser/tests/ParserSymbolTableTest.java 2 Sep 2003 20:05:20 -0000 1.14
+++ parser/org/eclipse/cdt/core/parser/tests/ParserSymbolTableTest.java 3 Sep 2003 20:20:48 -0000
@@ -2484,10 +2484,14 @@
IParameterizedSymbol constructor2 = table.newParameterizedSymbol( "A", TypeInfo.t_constructor );
constructor2.addParameter( TypeInfo.t_int, 0, null, false );
+ IParameterizedSymbol constructor3 = table.newParameterizedSymbol( "A", TypeInfo.t_constructor );
+ constructor3.addParameter( TypeInfo.t_char, 0, null, false );
+
classA.addConstructor( constructor1 );
classA.addConstructor( constructor2 );
+ classA.addConstructor( constructor3 );
- assertEquals( classA.getConstructors().size(), 2 );
+ assertEquals( classA.getConstructors().size(), 3 );
IParameterizedSymbol cloned = (IParameterizedSymbol) constructor2.clone();
try{
