| [cdt-patch] CView update |
Last Thursday, I submitted the attached patch and I haven't received any feedback. Did I do the right things? Is this something of interest? Was the patch rejected/accepted and I missed the follow-up message? Please let me know one way or another. :-) gene
--- Begin Message ---
- From: "Sally, Gene" <Gene.Sally@xxxxxxxxxxx>
- Date: Thu, 17 Jul 2003 22:43:13 -0400
- Thread-index: AcNMjQ/C5LbhxhQlTq+00+SDEzj46QASai5Q
- Thread-topic: [cdt-dev] Interesting "starter" work project
Here's the patch for CView after synchronizing with CVS. >> Keep up the great work! Thanks, I appreciate the opportunity to help out as my schedule permits. :-) gene -----Original Message----- From: Thomas Fletcher [mailto:ThomasF@xxxxxxx] Sent: Thursday, July 17, 2003 1:54 PM To: 'cdt-dev@xxxxxxxxxxx' Subject: RE: [cdt-dev] Interesting "starter" work project Gene, Can you be sure to do a synchronize with the head and then re-submit your patch to the cdt-patch@xxxxxxxxxxx mailing list. I applied it locally (but I don't have commit access to the UI) and there were some conflicts. Keep up the great work! Thanks, Thomas > -----Original Message----- > From: Sally, Gene [mailto:Gene.Sally@xxxxxxxxxxx] > Sent: July 16, 2003 11:19 PM > To: cdt-dev@xxxxxxxxxxx > Subject: RE: [cdt-dev] Interesting "starter" work project > > > Here's a patch for the work I did on CView. > > It does the following: > > - CView descends from ResourceNavigator > - Update Pattern filter so it's compatible with CView's new > parent class > - Update FilterSelectionAction to use ResourcePatternFilter > - Update FiltersContentProvider to use ResourcePatternFilter > - If something exists in the new build model for a project, > use that to populate the build menu. > > I created this patch using the tools in Eclipse, please let > me know if the format is incorrect and I'll turn around > another patch done correctly. > > I'd like to continue working on this, submitting my changes > as a bunch of smaller patches rather than one large patch, as > Thomas suggested. I'd like to work on the following: > > - Remove references to CLibFilter > I think this is dead code now, but removing this changes some > public methods that are referenced elsewhere. > > - Fix the collapse all control > After collapsing all, this should be disabled or turned into > an expand all. > > - Improve drag and drop > Drag and drop works on a per-file basis. I think it would be > nice if you could drag and drop functions/classes around, > sort of like a re-factoring operation. This could get sticky > because we'll also need to make sure referenced types are > correct transferred as well. > > - Improve filtering > I think it would be nice to filter on object types; for > example, exclude #include entries in the tree view. I would > also like to see some visual indication that the view is > filtered, indicating the number of items matched out of the > population, akin to the Tasks view. > > Of course, I'm more than happy to work on other things not mentioned. > > Thanks, > > gene > > -----Original Message----- > From: Sally, Gene > Sent: Wednesday, July 09, 2003 8:36 AM > To: cdt-dev@xxxxxxxxxxx > Subject: RE: [cdt-dev] Interesting "starter" work project > > Thomas, > > I've been plugging away at this. CView now descends from > ResourceNavigator and I've gotten some clean-up in as well. > For entertainment, I reworked the Make menu so it walks the > targets in ManagedBuildManager, but in order to get this all > the way working, the MakeAction class will need to be updated > to fit the new build model or, if that breaks too much other > stuff, I'll create a ManagedMakeAction class. > > Next, I'm going to get my head around drag and drop so it > starts doing the right thing. > > gene > > -----Original Message----- > From: Thomas Fletcher [mailto:thomasf@xxxxxxx] > Sent: Sunday, June 29, 2003 10:16 AM > To: cdt-dev@xxxxxxxxxxx > Subject: [cdt-dev] Interesting "starter" work project > > All, > > I started to get back to cleaning up the CView a bit today, > and I think > that for anyone > who is lurking out there and wanting to get involved, a great > project would > be to clean > up the CView so that it implements the IResourceNavigator > interface, likely > by inheriting > from the ResourceNavigator class. It is probably a good > couple of evenings > work if > anyone is interested. > > Thanks, > Thomas > > _______________________________________________ > cdt-dev mailing list > cdt-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/cdt-dev > _______________________________________________ > cdt-dev mailing list > cdt-dev@xxxxxxxxxxx > http://dev.eclipse.org/mailman/listinfo/cdt-dev > _______________________________________________ cdt-dev mailing list cdt-dev@xxxxxxxxxxx http://dev.eclipse.org/mailman/listinfo/cdt-devAttachment: cview.patch.2
Description: cview.patch.2
--- End Message ---