Re: [cdt-patch] Patch for Approval: Standard make info in cdtproject fil

["Douglas Schaefer" <dschaefe@xxxxxxxxxx>]

Yes, great points.  We will always need some kind of upgrade mechanism 
that will maintain existing data as the format changes.  My understanding 
from Sean's stuff is that the information here is new.

I gave a thought about synchronization.  The easiest mechanism would be to 
make sure you are calling these methods from the UI thread.  But we should 
probably provide some kind of mutual exclusion to allow access to this 
information from places such as the indexer thread.  And this applies to 
all information stored in cdtproject.  I'll give it a little more thought.

Doug Schaefer, Senior Software Developer
IBM Rational Software, Ottawa, Ontario, Canada



"Thomas Fletcher" <thomasf@xxxxxxx> 
Sent by: cdt-patch-admin@xxxxxxxxxxx
07/08/2003 09:16 AM
Please respond to
cdt-patch@xxxxxxxxxxx


To
<cdt-patch@xxxxxxxxxxx>
cc

Subject
Re: [cdt-patch] Patch for Approval: Standard make info in cdtproject file






Sounds good in principle (though I was looking at the patch, not at
the final code), things that I think we need to make note of
when the change occurs to move the data to the .cdtproject file:
- What will happen to historical users who had their values stored as
   preferences (I might be totally wrong here, perhaps there isn't 
anything
   which is migrating from a preference to a .cdtproject file, but I 
thought
I
   would ask).
- Are the methods for working with the .cdtproject file properly
  synchronized?  I don't have the source handy, just asking.

Thanks,
 Thomas

----- Original Message -----
From: "Douglas Schaefer" <dschaefe@xxxxxxxxxx>
To: <cdt-patch@xxxxxxxxxxx>
Sent: Monday, July 07, 2003 10:14 PM
Subject: [cdt-patch] Patch for Approval: Standard make info in cdtproject
file


> Hey gang,
>
> Here's one I'd like to get approval on.  This patch adds the ability to
> add arbitrary XML data to the cdtproject file.  I then use this to store
>
> the stuff Sean had put in the cdtbuild file for Standard Make projects.
> The intention is to do the same for the Managed Make projects and
> anything
> else we need to store in source control.
>
> I also cleaned up some of the exception handling in the
> StandardBuildManager.
>
> Thanks,
> Doug Schaefer, Senior Software Developer
> IBM Rational Software, Ottawa, Ontario, Canada
>
>
>

_______________________________________________
cdt-patch mailing list
cdt-patch@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/cdt-patch