| Re: Rejected Re: [cdt-patch] Fixes for PR 39476, 39477 + some cleanup |
|
Just to
clarify things: I didn't plan to do more work on general problem handling (as
JohnC assumed). The scope of these patches is still just task tags support. In
my mail I just oulined how existing mechanism for _task_tags_ support could
be extended to support general problem reporting. Existing CProblemReconciler
deals with task tags problems, only. There is no new functionality comparing to
already applied initial patch - it is just the code that was previously
piggybacked into CModelBuilder, and now it is extracted into separate class. We
can name it CTaskReconciler, for all that matters. Again, the only problems that
are handled by this mechanism are task tags.
The only reason to hook up task
reconciling with the indexer is because it is a proper location to
collect tasks; we need to parse all the sources in the project/workspace to
collect all the tasks, and indexer does exactly that. It doesn't affect
indexer behavior.
And ParserFactory doesn't
produce any CModel elements in this patch, does it?
I hope this clears up a possible
misunderstanding,
/Vic
|