[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [cdt-patch] Online Help plugin update > please commit
|
> Thank you Sebastien,
>
> Yes, this is a function of our tool and we will correct it
> for the next
> submission.
Great, thanks.
>
> Thank you again for alerting us to these issues and for
> checking in our
> changes.
No problem, my pleasure!
Sebastien
>
> Regards,
>
> Visnja Beg
> Manager, Information Development
> Rational Software
> IBM Software Group
> vbeg@xxxxxxxxxx
> 613-591-7939
>
>
>
>
> Sebastien
>
> Marineau
>
> <sebastien@xxxxxx
> To
> m>
> "'cdt-patch@xxxxxxxxxxx'"
> Sent by:
> <cdt-patch@xxxxxxxxxxx>
> cdt-patch-admin@e
> cc
> clipse.org Dejan
> Custic/Ottawa/IBM@IBMCA
>
> Subject
> RE: [cdt-patch] Online
> Help plugin
> 06/26/2003 01:27 update > please commit
>
> PM
>
>
>
>
>
> Please respond to
>
> cdt-patch@eclipse
>
> .org
>
>
>
>
>
>
>
>
>
> Hi Visnja,
>
> I've checked in most of your changes, with the exception of
> the plugin.xml and the plugin.properties files. In your patch,
> you replaced the plugin name and provider name with hard-coded
> versions (instead of relying on the properties file), and changed
> the version number back to 1.0. There was also some reference to
> a rational tool in the plugin.properties file.
> The diff for the rejected changes are below.
>
> On that topic, Tanya also has the same types of issues with her
> original diffs. Is this a function of the tool you are using? If so,
> is there any way you could configure your tool to do "the right
> thing" with the plugin.* files? If not, then we'll have to manually
> clean out all changes that come through.
>
> The rest was fine; I browsed the outline for the docs, this TOC and
> organization looks good!
>
> Thanks,
>
> Sebastien
>
> Index: plugin.properties
> ===================================================================
> RCS file: /home/tools/org.eclipse.cdt.doc.user/plugin.properties,v
> retrieving revision 1.2
> diff -c -r1.2 plugin.properties
> *** plugin.properties 1 May 2003 12:54:23 -0000 1.2
> --- plugin.properties 26 Jun 2003 17:23:07 -0000
> ***************
> *** 1,12 ****
> !
> ##############################################################
> ##############
>
> ###
> ! # Copyright (c) 2000, 2003 IBM Corporation and others.
> ! # All rights reserved. This program and the accompanying materials
> ! # are made available under the terms of the Common Public
> License v1.0
> ! # which accompanies this distribution, and is available at
> ! # http://www.eclipse.org/legal/cpl-v10.html
> ! #
> ! # Contributors:
> ! # Rational Software: IBM Software Group
> !
> ##############################################################
> ##############
>
> ###
> ! pluginName=Eclipse C/C++ Development User Guide
> ! providerName=Eclipse.org
> --- 1,4 ----
> ! <?xml version="1.0"?>
> ! <csHelp>
> ! <csHelpTopic viewID="default_help"
> helpTopic="com.rational.xtools.umlvisualizer.doc.default_cs_help"/>
> ! </csHelp>
> Index: plugin.xml
> ===================================================================
> RCS file: /home/tools/org.eclipse.cdt.doc.user/plugin.xml,v
> retrieving revision 1.2
> diff -c -r1.2 plugin.xml
> *** plugin.xml 1 May 2003 12:54:23 -0000 1.2
> --- plugin.xml 26 Jun 2003 17:23:07 -0000
> ***************
> *** 7,16 ****
>
> <plugin
>
> ! name = "%pluginName"
> id = "org.eclipse.cdt.doc.user"
> ! version = "1.1.0"
> ! provider-name = "%providerName">
> <!-- Configure the help contribution for this plugin -->
> <!-- This part should be in a documentation plugin -->
> <extension point="org.eclipse.help.toc">
> --- 7,16 ----
>
> <plugin
>
> ! name = "C/C++ Development User Guide"
> id = "org.eclipse.cdt.doc.user"
> ! version = "1.0"
> ! provider-name = "Rational Software: IBM Software Group">
> <!-- Configure the help contribution for this plugin -->
> <!-- This part should be in a documentation plugin -->
> <extension point="org.eclipse.help.toc">
>
> > -----Original Message-----
> > From: Visnja Beg [mailto:vbeg@xxxxxxxxxx]
> > Sent: Thursday, June 26, 2003 10:37 AM
> > To: cdt-patch@xxxxxxxxxxx
> > Cc: Dejan Custic
> > Subject: [cdt-patch] Online Help plugin update > please commit
> >
> >
> >
> >
> >
> >
> > This is the first update of the online help with a full TOC
> > defined, and
> > some content in topics.
> >
> > This version should be used for an initial review by the CDT
> > working group.
> > Please send any comments to Tanya de Sousa (tdesous@xxxxxxxxxx), and
> > myself.
> >
> > Since I do not have commit rights, Doug Schaefer, can you
> > please commit
> > this plugin.
> > (See attached file: org.eclipse.cdt.doc.user.zip)
> >
> > Thank you,
> >
> > Visnja Beg
> > Manager, Information Development
> > Rational Software
> > IBM Software Group
> > vbeg@xxxxxxxxxx
> > 613-591-7939
> >
> _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-patch
>
>
> _______________________________________________
> cdt-patch mailing list
> cdt-patch@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/cdt-patch
>
