| [cdt-patch] Cleanup: removed unused and internal methods from ICValue |
|
Index:
ChangeLog
=================================================================== RCS file: /home/tools/org.eclipse.cdt.debug.core/ChangeLog,v retrieving revision 1.205 diff -u -r1.205 ChangeLog --- ChangeLog 10 Jun 2003 22:33:55 -0000 1.205 +++ ChangeLog 11 Jun 2003 22:58:00 -0000 @@ -1,3 +1,13 @@ +2003-06-11 Mikhail Khodjaiants + The unused 'getUnderlyingValueString' method has been removed from ICValue and CValue. + The methods 'setChanged' and 'getUnderlyingValue' are only for internal usage and + have been removed from ICValue. + * ICValue.java + * CArrayPartitionValue.java + * CValueFactory.java + * CValue.java + * CVariable.java + 2003-06-10 Mikhail Khodjaiants Refactoring: moved the type and value related methods from ICVariable to ICType and ICValue. * ICType.java: new Index: src/org/eclipse/cdt/debug/core/model/ICValue.java =================================================================== RCS file: /home/tools/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/model/ICValue.java,v retrieving revision 1.7 diff -u -r1.7 ICValue.java --- src/org/eclipse/cdt/debug/core/model/ICValue.java 10 Jun 2003 22:33:55 -0000 1.7 +++ src/org/eclipse/cdt/debug/core/model/ICValue.java 11 Jun 2003 22:58:01 -0000 @@ -6,8 +6,6 @@ package org.eclipse.cdt.debug.core.model; -import org.eclipse.cdt.debug.core.cdi.model.ICDIValue; -import org.eclipse.debug.core.DebugException; import org.eclipse.debug.core.model.IValue; /** @@ -18,19 +16,7 @@ */ public interface ICValue extends IValue { - /** - * Returns the underlying CDI value for this value. - */ - ICDIValue getUnderlyingValue(); - - /** - * Returns the string representation of the underlying CDI value for this value. - */ - String getUnderlyingValueString(); - String evaluateAsExpression(); - - void setChanged( boolean changed ) throws DebugException; boolean isNaN(); Index: src/org/eclipse/cdt/debug/internal/core/model/CArrayPartitionValue.java =================================================================== RCS file: /home/tools/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CArrayPartitionValue.java,v retrieving revision 1.10 diff -u -r1.10 CArrayPartitionValue.java --- src/org/eclipse/cdt/debug/internal/core/model/CArrayPartitionValue.java 10 Jun 2003 22:33:55 -0000 1.10 +++ src/org/eclipse/cdt/debug/internal/core/model/CArrayPartitionValue.java 11 Jun 2003 22:58:01 -0000 @@ -11,7 +11,6 @@ import java.util.Iterator; import java.util.List; -import org.eclipse.cdt.debug.core.cdi.model.ICDIValue; import org.eclipse.cdt.debug.core.cdi.model.ICDIVariable; import org.eclipse.cdt.debug.core.model.ICValue; import org.eclipse.debug.core.DebugException; @@ -58,22 +57,6 @@ } /* (non-Javadoc) - * @see org.eclipse.cdt.debug.core.ICValue#getType() - */ - public int getType() - { - return 0; - } - - /* (non-Javadoc) - * @see org.eclipse.cdt.debug.core.ICValue#getUnderlyingValue() - */ - public ICDIValue getUnderlyingValue() - { - return null; - } - - /* (non-Javadoc) * @see org.eclipse.debug.core.model.IValue#getReferenceTypeName() */ public String getReferenceTypeName() throws DebugException @@ -131,9 +114,6 @@ return fEnd; } - /* (non-Javadoc) - * @see org.eclipse.cdt.debug.core.model.ICValue#setChanged(boolean) - */ public void setChanged( boolean changed ) throws DebugException { Iterator it = fVariables.iterator(); @@ -141,14 +121,6 @@ { ((CVariable)it.next()).setChanged( changed ); } - } - - /* (non-Javadoc) - * @see org.eclipse.cdt.debug.core.model.ICValue#getUnderlyingValueString() - */ - public String getUnderlyingValueString() - { - return null; } /* (non-Javadoc) Index: src/org/eclipse/cdt/debug/internal/core/model/CValue.java =================================================================== RCS file: /home/tools/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CValue.java,v retrieving revision 1.29 diff -u -r1.29 CValue.java --- src/org/eclipse/cdt/debug/internal/core/model/CValue.java 10 Jun 2003 22:33:55 -0000 1.29 +++ src/org/eclipse/cdt/debug/internal/core/model/CValue.java 11 Jun 2003 22:58:01 -0000 @@ -168,9 +168,6 @@ return false; } - /* (non-Javadoc) - * @see org.eclipse.cdt.debug.core.ICValue#getUnderlyingValue() - */ public ICDIValue getUnderlyingValue() { return fCDIValue; @@ -514,26 +511,6 @@ { } return result; - } - - /* (non-Javadoc) - * @see org.eclipse.cdt.debug.core.model.ICValue#getUnderlyingValueString() - */ - public String getUnderlyingValueString() - { - String valueString = null; - if ( getUnderlyingValue() != null ) - { - try - { - valueString = getUnderlyingValue().getValueString(); - } - catch( CDIException e ) - { - valueString = e.getMessage(); - } - } - return valueString; } /* (non-Javadoc) Index: src/org/eclipse/cdt/debug/internal/core/model/CValueFactory.java =================================================================== RCS file: /home/tools/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CValueFactory.java,v retrieving revision 1.5 diff -u -r1.5 CValueFactory.java --- src/org/eclipse/cdt/debug/internal/core/model/CValueFactory.java 2 Dec 2002 23:22:22 -0000 1.5 +++ src/org/eclipse/cdt/debug/internal/core/model/CValueFactory.java 11 Jun 2003 22:58:01 -0000 @@ -7,7 +7,6 @@ package org.eclipse.cdt.debug.internal.core.model; import org.eclipse.cdt.debug.core.cdi.model.ICDIValue; -import org.eclipse.cdt.debug.core.model.ICValue; import org.eclipse.debug.core.DebugException; /** @@ -18,12 +17,12 @@ */ public class CValueFactory { - static public ICValue createValue( CVariable parent, ICDIValue cdiValue ) throws DebugException + static public CValue createValue( CVariable parent, ICDIValue cdiValue ) throws DebugException { return new CValue( parent, cdiValue ); } - static public ICValue createGlobalValue( CVariable parent, ICDIValue cdiValue ) throws DebugException + static public CValue createGlobalValue( CVariable parent, ICDIValue cdiValue ) throws DebugException { return new CGlobalValue( parent, cdiValue ); } Index: src/org/eclipse/cdt/debug/internal/core/model/CVariable.java =================================================================== RCS file: /home/tools/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CVariable.java,v retrieving revision 1.38 diff -u -r1.38 CVariable.java --- src/org/eclipse/cdt/debug/internal/core/model/CVariable.java 10 Jun 2003 22:33:55 -0000 1.38 +++ src/org/eclipse/cdt/debug/internal/core/model/CVariable.java 11 Jun 2003 22:58:01 -0000 @@ -60,7 +60,7 @@ /** * Cache of current value - see #getValue(). */ - protected ICValue fValue; + protected CValue fValue; /** * The name of this variable. @@ -270,7 +270,7 @@ if ( getValue() != null && getValue() instanceof ICValue ) { fChanged = changed; - ((ICValue)getValue()).setChanged( changed ); + ((CValue)getValue()).setChanged( changed ); } } |