[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: Applied [HEAD & Parser_SymbolTable] Re: [cdt-patch] Fix for P R 38065
|
Title: Message
Yes, you're right. Here are updates for
ui.tests and core/parser/ChangeLog. Hope it is sufficient.
/Vic
Thanks for the
patch.
For future reference:
- ChangeLogs should be updated
on every patch (a short description is fine with me)
- adding a Junit test to the
org.eclipse.cdt.ui.tests plugin to be joined into our
AutomatedIntegrationSuite.java is highly encouraged so that we can see that a
new bug has been fixed without the committer reproducing the testcase.
Thanks again,
JohnC
victor.mozgin@xxxxxxxxxxxxx
Sent by: cdt-patch-admin@xxxxxxxxxxx
06/04/2003 03:47 PM
|
Please respond
to
cdt-patch@xxxxxxxxxxx |
|
|
To
| cdt-patch@xxxxxxxxxxx
|
|
cc
|
|
|
Subject
| [cdt-patch] Fix for PR
38065 |
|
Here is another small patch. The problem is
caused by the scanner: it mistreated '\' characters. getChar() handles "'\' as
the last character on the line" scenario, where '\' and the end-of-line are
correctly skipped (imitating preprocessor activity). But it didn't backtrack
properly in other cases, effectively skipping '\' characters anywhere else in
the code (outside strings). You could write
cl\ass C\Foo\Bar
{
and it was automagically transformed to
class CFooBar {
for
the parser.
Now getChar() does additional ungetChar() in case '\' is
not the last character on the line (and it throws ScannerException, from
ungetChar()).
/Vic
Attachment:
PR38065_test.patch
Description: Binary data
Attachment:
PR38065_ChangeLog.patch
Description: Binary data
