Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-patch] New Parser in HEAD branch

> 
> This is a pretty big patch, but it is the merge of the NewParser1 branch
> into the HEAD branch.  We will do futher work on the parser and everything
> associated with it in the HEAD branch.  Highlights of the patch include:
> 
>  
> 
> *	Parser in the "parser" source folder in cdt.core
> *	Preference in the C/C++ preference page to enable/disable use of the
> new parser (disabled by default)

Suggestion:
You could probably use the Core plugin preferences instead which will make more
sense then setting this on the UI plugin, and there will be no hack like this.

 +               
 +               // TODO - temporary kludge (maybe) to make sure the core preferences
 +               // are kept in sync with the stored preferences
 +               CCorePlugin.getDefault().setUseNewParser(CPluginPreferencePage.useNewParser());
 

And then do the check correctly in the parser:

 CCorePlugin.getDefault().getPluginPreferences().getDefaultString(PREF_USE_NEW_PARSER);

Since the preference affect a Core setting doing this on the Core plugin will simplify things,
i.e. no need to sync.



Back to the top